Update @types/node and fix problems with types

junderw · junderw · commit 34b0b525fc78 · 2019-09-12T15:20:33.000+09:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -48,7 +48,7 @@
     "types"
   ],
   "dependencies": {
-    "@types/node": "10.12.18",
+    "@types/node": "12.7.5",
     "bech32": "^1.1.2",
     "bip174": "^1.0.1",
     "bip32": "^2.0.4",
diff --git a/test/integration/cltv.spec.ts b/test/integration/cltv.spec.ts
@@ -10,7 +10,7 @@ function toOutputScript(address: string): Buffer {
 }
 
 function idToHash(txid: string): Buffer {
-  return Buffer.from(txid, 'hex').reverse() as Buffer;
+  return Buffer.from(txid, 'hex').reverse();
 }
 
 const alice = bitcoin.ECPair.fromWIF(
diff --git a/test/integration/csv.spec.ts b/test/integration/csv.spec.ts
@@ -10,7 +10,7 @@ function toOutputScript(address: string): Buffer {
 }
 
 function idToHash(txid: string): Buffer {
-  return Buffer.from(txid, 'hex').reverse() as Buffer;
+  return Buffer.from(txid, 'hex').reverse();
 }
 
 const alice = bitcoin.ECPair.fromWIF(
diff --git a/test/psbt.spec.ts b/test/psbt.spec.ts
@@ -14,7 +14,7 @@ const initBuffers = (object: any): typeof preFixtures =>
     const data = result[1];
     const encoding = result[2];
 
-    return Buffer.from(data, encoding);
+    return Buffer.from(data, encoding as any);
   });
 
 const fixtures = initBuffers(preFixtures);
diff --git a/types/address.d.ts b/types/address.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Network } from './networks';
 export interface Base58CheckResult {
     hash: Buffer;
diff --git a/types/block.d.ts b/types/block.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Transaction } from './transaction';
 export declare class Block {
     static fromBuffer(buffer: Buffer): Block;
diff --git a/types/bufferutils.d.ts b/types/bufferutils.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function readUInt64LE(buffer: Buffer, offset: number): number;
 export declare function writeUInt64LE(buffer: Buffer, value: number, offset: number): number;
 export declare function reverseBuffer(buffer: Buffer): Buffer;
diff --git a/types/classify.d.ts b/types/classify.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 declare const types: {
     P2MS: string;
     NONSTANDARD: string;
diff --git a/types/crypto.d.ts b/types/crypto.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function ripemd160(buffer: Buffer): Buffer;
 export declare function sha1(buffer: Buffer): Buffer;
 export declare function sha256(buffer: Buffer): Buffer;
diff --git a/types/ecpair.d.ts b/types/ecpair.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Network } from './networks';
 interface ECPairOptions {
     compressed?: boolean;
diff --git a/types/payments/index.d.ts b/types/payments/index.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Network } from '../networks';
 import { p2data as embed } from './embed';
 import { p2ms } from './p2ms';
diff --git a/types/psbt.d.ts b/types/psbt.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Psbt as PsbtBase } from 'bip174';
 import { KeyValue, PsbtGlobalUpdate, PsbtInput, PsbtInputUpdate, PsbtOutput, PsbtOutputUpdate, TransactionInput } from 'bip174/src/lib/interfaces';
 import { Signer, SignerAsync } from './ecpair';
diff --git a/types/script.d.ts b/types/script.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Stack } from './payments';
 import * as scriptNumber from './script_number';
 import * as scriptSignature from './script_signature';
diff --git a/types/script_number.d.ts b/types/script_number.d.ts
@@ -1,3 +1,2 @@
-/// <reference types="node" />
 export declare function decode(buffer: Buffer, maxLength?: number, minimal?: boolean): number;
 export declare function encode(_number: number): Buffer;
diff --git a/types/script_signature.d.ts b/types/script_signature.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 interface ScriptSignature {
     signature: Buffer;
     hashType: number;
diff --git a/types/templates/multisig/input.d.ts b/types/templates/multisig/input.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Stack } from '../../payments';
 export declare function check(script: Buffer | Stack, allowIncomplete?: boolean): boolean;
 export declare namespace check {
diff --git a/types/templates/multisig/output.d.ts b/types/templates/multisig/output.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Stack } from '../../payments';
 export declare function check(script: Buffer | Stack, allowIncomplete?: boolean): boolean;
 export declare namespace check {
diff --git a/types/templates/nulldata.d.ts b/types/templates/nulldata.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function check(script: Buffer | Array<number | Buffer>): boolean;
 export declare namespace check {
     var toJSON: () => string;
diff --git a/types/templates/pubkey/input.d.ts b/types/templates/pubkey/input.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Stack } from '../../payments';
 export declare function check(script: Buffer | Stack): boolean;
 export declare namespace check {
diff --git a/types/templates/pubkey/output.d.ts b/types/templates/pubkey/output.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Stack } from '../../payments';
 export declare function check(script: Buffer | Stack): boolean;
 export declare namespace check {
diff --git a/types/templates/pubkeyhash/input.d.ts b/types/templates/pubkeyhash/input.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Stack } from '../../payments';
 export declare function check(script: Buffer | Stack): boolean;
 export declare namespace check {
diff --git a/types/templates/pubkeyhash/output.d.ts b/types/templates/pubkeyhash/output.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function check(script: Buffer | Array<number | Buffer>): boolean;
 export declare namespace check {
     var toJSON: () => string;
diff --git a/types/templates/scripthash/input.d.ts b/types/templates/scripthash/input.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function check(script: Buffer | Array<number | Buffer>, allowIncomplete?: boolean): boolean;
 export declare namespace check {
     var toJSON: () => string;
diff --git a/types/templates/scripthash/output.d.ts b/types/templates/scripthash/output.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function check(script: Buffer | Array<number | Buffer>): boolean;
 export declare namespace check {
     var toJSON: () => string;
diff --git a/types/templates/witnesscommitment/output.d.ts b/types/templates/witnesscommitment/output.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function check(script: Buffer | Array<number | Buffer>): boolean;
 export declare namespace check {
     var toJSON: () => string;
diff --git a/types/templates/witnesspubkeyhash/input.d.ts b/types/templates/witnesspubkeyhash/input.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Stack } from '../../payments';
 export declare function check(script: Buffer | Stack): boolean;
 export declare namespace check {
diff --git a/types/templates/witnesspubkeyhash/output.d.ts b/types/templates/witnesspubkeyhash/output.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function check(script: Buffer | Array<number | Buffer>): boolean;
 export declare namespace check {
     var toJSON: () => string;
diff --git a/types/templates/witnessscripthash/input.d.ts b/types/templates/witnessscripthash/input.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function check(chunks: Buffer[], allowIncomplete?: boolean): boolean;
 export declare namespace check {
     var toJSON: () => string;
diff --git a/types/templates/witnessscripthash/output.d.ts b/types/templates/witnessscripthash/output.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export declare function check(script: Buffer | Array<number | Buffer>): boolean;
 export declare namespace check {
     var toJSON: () => string;
diff --git a/types/transaction.d.ts b/types/transaction.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 export interface BlankOutput {
     script: Buffer;
     valueBuffer: Buffer;
diff --git a/types/transaction_builder.d.ts b/types/transaction_builder.d.ts
@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Signer } from './ecpair';
 import { Network } from './networks';
 import { Transaction } from './transaction';

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ function toOutputScript(address: string): Buffer {`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`function idToHash(txid: string): Buffer {`
`13`		`- return Buffer.from(txid, 'hex').reverse() as Buffer;`
	`13`	`+ return Buffer.from(txid, 'hex').reverse();`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`const alice = bitcoin.ECPair.fromWIF(`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/// <reference types="node" />`
`2`	`1`	`import { Network } from './networks';`
`3`	`2`	`export interface Base58CheckResult {`
`4`	`3`	`hash: Buffer;`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/// <reference types="node" />`
`2`	`1`	`import { Transaction } from './transaction';`
`3`	`2`	`export declare class Block {`
`4`	`3`	`static fromBuffer(buffer: Buffer): Block;`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/// <reference types="node" />`
`2`	`1`	`declare const types: {`
`3`	`2`	`P2MS: string;`
`4`	`3`	`NONSTANDARD: string;`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/// <reference types="node" />`
`2`	`1`	`export declare function ripemd160(buffer: Buffer): Buffer;`
`3`	`2`	`export declare function sha1(buffer: Buffer): Buffer;`
`4`	`3`	`export declare function sha256(buffer: Buffer): Buffer;`