Skip to content

Commit 793bf5a

Browse files
authored
Merge pull request #1657 from bitcoincoretech/issue_1477
#1477 - Remove TransactionBuilder
2 parents 33f36f3 + 1630311 commit 793bf5a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

80 files changed

+265
-7845
lines changed

src/classify.js

Lines changed: 0 additions & 59 deletions
This file was deleted.

src/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,3 @@ var script_1 = require('./script');
2222
exports.opcodes = script_1.OPS;
2323
var transaction_1 = require('./transaction');
2424
exports.Transaction = transaction_1.Transaction;
25-
var transaction_builder_1 = require('./transaction_builder');
26-
exports.TransactionBuilder = transaction_builder_1.TransactionBuilder;

src/psbt.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,7 @@ class Psbt {
6969
__NON_WITNESS_UTXO_BUF_CACHE: [],
7070
__TX_IN_CACHE: {},
7171
__TX: this.data.globalMap.unsignedTx.tx,
72-
// Old TransactionBuilder behavior was to not confirm input values
73-
// before signing. Even though we highly encourage people to get
72+
// Even though we highly encourage people to get
7473
// the full parent transaction to verify values, the ability to
7574
// sign non-segwit inputs without the full transaction was often
7675
// requested. So the only way to activate is to use @ts-ignore.
@@ -998,8 +997,7 @@ function getHashForSig(inputIndex, input, cache, forValidate, sighashTypes) {
998997
console.warn(
999998
'Warning: Signing non-segwit inputs without the full parent transaction ' +
1000999
'means there is a chance that a miner could feed you incorrect information ' +
1001-
'to trick you into paying large fees. This behavior is the same as the old ' +
1002-
'TransactionBuilder class when signing non-segwit scripts. You are not ' +
1000+
'to trick you into paying large fees. You are not ' +
10031001
'able to export this Psbt with toBuffer|toBase64|toHex since it is not ' +
10041002
'BIP174 compliant.\n*********************\nPROCEED WITH CAUTION!\n' +
10051003
'*********************',

src/templates/multisig/index.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/templates/multisig/input.js

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/templates/multisig/output.js

Lines changed: 0 additions & 27 deletions
This file was deleted.

src/templates/nulldata.js

Lines changed: 0 additions & 15 deletions
This file was deleted.

src/templates/pubkey/index.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/templates/pubkey/input.js

Lines changed: 0 additions & 12 deletions
This file was deleted.

src/templates/pubkey/output.js

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)