Merge pull request #1975 from wakqasahmed/fix-issue-1974

Fixes issue#1974

Author: junderw

src/address.js

@@ -46,7 +46,7 @@ function fromBase58Check(address) {
   // TODO: 4.0.0, move to "toOutputScript"
   if (payload.length < 21) throw new TypeError(address + ' is too short');
   if (payload.length > 21) throw new TypeError(address + ' is too long');
-  const version = payload.readUint8(0);
+  const version = payload.readUInt8(0);
   const hash = payload.slice(1);
   return { version, hash };
 }

test/bufferutils.spec.ts

@@ -316,7 +316,7 @@ describe('bufferutils', () => {
       }
     }
 
-    it('readUint8', () => {
+    it('readUInt8', () => {
       const values = [0, 1, 0xfe, 0xff];
       const buffer = Buffer.from([0, 1, 0xfe, 0xff]);
       const bufferReader = new BufferReader(buffer);

ts_src/address.ts

@@ -59,7 +59,7 @@ export function fromBase58Check(address: string): Base58CheckResult {
   if (payload.length < 21) throw new TypeError(address + ' is too short');
   if (payload.length > 21) throw new TypeError(address + ' is too long');
 
-  const version = payload.readUint8(0);
+  const version = payload.readUInt8(0);
   const hash = payload.slice(1);
 
   return { version, hash };