Skip to content

Commit ec61b99

Browse files
committed
#1477 do not remove comments refering TransactionBuilder, but instead mention that TransactionBuilder was removed
1 parent b56273a commit ec61b99

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

ts_src/psbt.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ export class Psbt {
117117
__NON_WITNESS_UTXO_BUF_CACHE: [],
118118
__TX_IN_CACHE: {},
119119
__TX: (this.data.globalMap.unsignedTx as PsbtTransaction).tx,
120+
// Psbt's predecesor (TransactionBuilder - now removed) behavior
121+
// was to not confirm input values before signing.
120122
// Even though we highly encourage people to get
121123
// the full parent transaction to verify values, the ability to
122124
// sign non-segwit inputs without the full transaction was often
@@ -1294,7 +1296,8 @@ function getHashForSig(
12941296
console.warn(
12951297
'Warning: Signing non-segwit inputs without the full parent transaction ' +
12961298
'means there is a chance that a miner could feed you incorrect information ' +
1297-
'to trick you into paying large fees. You are not ' +
1299+
'to trick you into paying large fees. This behavior is the same as Psbt\'s predecesor ' +
1300+
'(TransactionBuilder - now removed) when signing non-segwit scripts. You are not ' +
12981301
'able to export this Psbt with toBuffer|toBase64|toHex since it is not ' +
12991302
'BIP174 compliant.\n*********************\nPROCEED WITH CAUTION!\n' +
13001303
'*********************',

0 commit comments

Comments
 (0)