Migrating to local implementation of Usafe.As; Using [ThreadStatic] instead of ThreadLocal due to lower overhead

Author: pachanga

src/vm/coro.cs

@@ -30,25 +30,18 @@ public virtual void Cleanup(VM.Frame frm, VM.ExecState exec) {}
 
 public class CoroutinePool
 {
-  //TODO: add debug inspection for concrete types
+  //TODO: add debug inspection for concrete types?
   static class PoolHolder<T> where T : Coroutine
   {
-    //TODO: alternative implemenation, check if it's simpler and faster?
-    //[ThreadStatic]
-    //static public VM.Pool<Coroutine> _pool;
-    //static public VM.Pool<Coroutine> pool {
-    //  get {
-    //    if(_pool == null) 
-    //      _pool = new VM.Pool<Coroutine>(); 
-    //    return _pool;
-    //  }
-    //}
-
-    public static System.Threading.ThreadLocal<Pool<Coroutine>> pool =
-      new System.Threading.ThreadLocal<Pool<Coroutine>>(() =>
-      {
-        return new Pool<Coroutine>();
-      });
+    [ThreadStatic]
+    static public Pool<Coroutine> _pool;
+    static public Pool<Coroutine> pool {
+      get {
+        if(_pool == null) 
+          _pool = new Pool<Coroutine>(); 
+        return _pool;
+      }
+    }
   }
 
   internal int hits;
@@ -73,12 +66,12 @@ public int NewCount {
   }
 
 #if BHL_TEST
-  public HashSet<VM.Pool<Coroutine>> pools_tracker = new HashSet<VM.Pool<Coroutine>>(); 
+  public HashSet<Pool<Coroutine>> pools_tracker = new HashSet<Pool<Coroutine>>(); 
 #endif
 
   static public T New<T>(VM vm) where T : Coroutine, new()
   {
-    var pool = PoolHolder<T>.pool.Value;
+    var pool = PoolHolder<T>.pool;
 
     Coroutine coro = null;
     if(pool.stack.Count == 0)

src/vm/util/extensions.cs

@@ -95,6 +95,27 @@ public static void SetFuncAttrib(this FuncSignatureAttrib attrib, ref byte other
     //      these bits in the target value and 'or' the bits we want to set
     other = (byte)((other & (byte)~FuncSignatureAttrib.FuncAttribMask) | (byte)attrib);
   }
+  
+  [MethodImpl(MethodImplOptions.AggressiveInlining)]
+  public static unsafe int SizeOf<T>() where T : unmanaged
+  {
+    return sizeof(T);
+  }
+  
+  [MethodImpl(MethodImplOptions.AggressiveInlining)]
+  public static unsafe ref T UsafeAsRef<T>(void* source) where T : unmanaged
+  {
+    return ref *(T*)source;
+  }  
+  
+  [MethodImpl(MethodImplOptions.AggressiveInlining)]
+  public static unsafe ref TTo UnsafeAs<TFrom, TTo>(ref TFrom source) where TTo : unmanaged where TFrom : unmanaged
+  {
+    fixed(void* p = &source)
+    {
+      return ref UsafeAsRef<TTo>(p);
+    }
+  }  
 }
 
 }

src/vm/util/refc_list.cs

@@ -14,17 +14,21 @@ public class RefcList<T> : List<T>, IValRefcounted, IDisposable
    public int refs => _refs; 
 
    static class PoolHolder<T1>
-   {
-     public static System.Threading.ThreadLocal<Pool<RefcList<T1>>> pool =
-       new System.Threading.ThreadLocal<Pool<RefcList<T1>>>(() =>
-       {
-         return new Pool<RefcList<T1>>();
-       });
+   { 
+     [ThreadStatic]
+     static public Pool<RefcList<T1>> _pool;
+     public static Pool<RefcList<T1>> pool {
+      get {
+        if(_pool == null) 
+          _pool = new Pool<RefcList<T1>>(); 
+        return _pool;
+      }
+     }
    }
 
    static public RefcList<T> New()
    {
-     var pool = PoolHolder<T>.pool.Value;
+     var pool = PoolHolder<T>.pool;
 
      RefcList<T> list = null;
      if(pool.stack.Count == 0)

src/vm/util/val_list_adapter.cs

@@ -26,16 +26,20 @@ public class ValList<T> : IList<T>, IValRefcounted, IDisposable
 
   static class PoolHolder<T1>
   {
-    public static System.Threading.ThreadLocal<Pool<ValList<T1>>> pool =
-      new System.Threading.ThreadLocal<Pool<ValList<T1>>>(() =>
-      {
-        return new Pool<ValList<T1>>();
-      });
+     [ThreadStatic]
+     static public Pool<ValList<T1>> _pool;
+     public static Pool<ValList<T1>> pool {
+      get {
+        if(_pool == null) 
+          _pool = new Pool<ValList<T1>>(); 
+        return _pool;
+      }
+     }
   }
 
   static public ValList<T> New(ValList lst, Func<Val, T> val2native)
   {
-    var pool = PoolHolder<T>.pool.Value;
+    var pool = PoolHolder<T>.pool;
 
     ValList<T> vls = null;
     if(pool.stack.Count == 0)

src/vm/val.cs

@@ -409,11 +409,11 @@ public void SetBlob<T>(ref T val, IType type) where T : unmanaged
   {
     Reset();
 
-    int size = Marshal.SizeOf<T>();
+    int size = Extensions.SizeOf<T>();
 
     var data = ArrayPool<byte>.Shared.Rent(size);
 
-    Unsafe.As<byte, T>(ref data[0]) = val;
+    Extensions.UnsafeAs<byte, T>(ref data[0]) = val;
 
     this.type = type;
     _blob_size = size;
@@ -430,7 +430,7 @@ public void SetBlob<T>(T val, IType type) where T : unmanaged
   public ref T GetBlob<T>() where T : unmanaged
   {
     byte[] data = (byte[])_obj;
-    return ref Unsafe.As<byte, T>(ref data[0]);
+    return ref Extensions.UnsafeAs<byte, T>(ref data[0]);
   }
 
   [MethodImpl(MethodImplOptions.AggressiveInlining)]

src/vm/version.cs

@@ -2,7 +2,7 @@ namespace bhl {
 
 public static class Version 
 {
-  public static string Name = "v2.0.0-beta192";
+  public static string Name = "v2.0.0-beta193";
 }
 
 }