Skip to content

Commit 6599a8a

Browse files
authored
make Data JSON-like, fix json matcher (#104)
1 parent 0fa5474 commit 6599a8a

File tree

2 files changed

+17
-9
lines changed

2 files changed

+17
-9
lines changed

src/bitdrift_public/protobuf/logging/v1/payload.proto

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,19 @@ message Data {
2424
double double_data = 4;
2525
int64 sint_data = 5;
2626
bool bool_data = 6;
27+
MapData map_data = 7;
28+
ArrayData array_data = 8;
2729
}
2830
}
2931

32+
message MapData {
33+
map<string, Data> entries = 1;
34+
}
35+
36+
message ArrayData {
37+
repeated Data items = 1;
38+
}
39+
3040
enum LogType {
3141
// Normal logs, from application code.
3242
NORMAL = 0;

src/bitdrift_public/protobuf/value_matcher/v1/value_matcher.proto

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,16 @@ message SemVerValueMatch {
6464

6565
message JsonPathValueMatch {
6666
Operator operator = 1 [(validate.rules).enum.defined_only = true];
67-
message JsonPath {
68-
message KeyOrIndex {
69-
oneof key_or_index {
70-
option (validate.required) = true;
67+
message KeyOrIndex {
68+
oneof key_or_index {
69+
option (validate.required) = true;
7170

72-
string key = 1 [(validate.rules).string = {min_len: 1}];
73-
int32 index = 2;
74-
}
71+
string key = 1 [(validate.rules).string = {min_len: 1}];
72+
int32 index = 2;
7573
}
76-
77-
string path = 1 [(validate.rules).string = {min_len: 1}];
7874
}
75+
76+
repeated KeyOrIndex key_or_index = 3 [(validate.rules).repeated = {min_items: 1}];
7977
string match_value = 2 [(validate.rules).string = {min_len: 1}];
8078
}
8179

0 commit comments

Comments
 (0)