Prevent a null Capture.logger instance inside onBeforeReportSend callback

Author: FranAguilera

platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/Capture.kt

@@ -689,6 +689,10 @@ object Capture {
 
             default.set(LoggerState.Started(loggerImpl))
 
+            // Must be initialized right after the logger state is set to avoid a null
+            // Capture.logger() reference when onBeforeSend callbacks are triggered.
+            loggerImpl.initIssueReporter()
+
             val sdkConfiguredDuration =
                 SdkConfiguredDuration(
                     wholeStartDuration = startSdkTimer.elapsedNow(),

platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/LoggerImpl.kt

@@ -98,6 +98,7 @@ internal class LoggerImpl(
     internal val webViewConfiguration: WebViewConfiguration? = configuration.webViewConfiguration
 
     private val metadataProvider: MetadataProvider
+    private val sdkDirectory: String
     private val batteryMonitor = BatteryMonitor(context)
     private val powerMonitor = PowerMonitor(context)
     private val diskUsageMonitor: DiskUsageMonitor
@@ -162,7 +163,7 @@ internal class LoggerImpl(
                 okHttpClient = sharedOkHttpClient,
             )
 
-        val sdkDirectory = SdkDirectory.getPath(context)
+        sdkDirectory = SdkDirectory.getPath(context)
 
         val localErrorReporter =
             errorReporter ?: ErrorReporterService(
@@ -286,14 +287,6 @@ internal class LoggerImpl(
 
         previousRunInfoResolver.initLegacyWatcher(sdkDirectory)
 
-        // issue reporter needs to be initialized after appExitLogger and the jniLogger
-        issueReporter?.init(
-            activityManager = activityManager,
-            sdkDirectory = sdkDirectory,
-            clientAttributes = clientAttributes,
-            completedReportsProcessor = this,
-        )
-
         startDebugOperationsAsNeeded(context)
     }
 
@@ -684,6 +677,19 @@ internal class LoggerImpl(
 
     internal fun getPreviousRunInfo(): PreviousRunInfo? = previousRunInfoResolver.get(activityManager)
 
+    /**
+     * Initializes the issue reporter. Must be called immediately right after the LoggerImpl is created
+     * so we can guarantee that any calls to Capture.Logger.* are valid within `onBeforeReportSend`
+     */
+    internal fun initIssueReporter() {
+        issueReporter?.init(
+            activityManager = activityManager,
+            sdkDirectory = sdkDirectory,
+            clientAttributes = clientAttributes,
+            completedReportsProcessor = this,
+        )
+    }
+
     private fun startDebugOperationsAsNeeded(context: Context) {
         if (!BuildTypeChecker.isDebuggable(context)) {
             return