Add a few more tests

Author: FranAguilera

platform/jvm/capture/src/test/kotlin/io/bitdrift/capture/reports/exitinfo/PreviousRunInfoResolverTest.kt

@@ -8,11 +8,13 @@
 package io.bitdrift.capture.reports.exitinfo
 
 import android.app.ActivityManager
+import android.app.ApplicationExitInfo
 import com.nhaarman.mockitokotlin2.any
 import com.nhaarman.mockitokotlin2.eq
 import com.nhaarman.mockitokotlin2.mock
 import com.nhaarman.mockitokotlin2.never
 import com.nhaarman.mockitokotlin2.verify
+import com.nhaarman.mockitokotlin2.whenever
 import io.bitdrift.capture.IInternalLogger
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.Before
@@ -31,18 +33,18 @@ class PreviousRunInfoResolverTest {
 
     private val internalLogger: IInternalLogger = mock()
     private val activityManager: ActivityManager = mock()
-    private lateinit var resolver: PreviousRunInfoResolver
+    private lateinit var previousRunInfoResolver: PreviousRunInfoResolver
 
     @Before
     fun setUp() {
-        resolver = PreviousRunInfoResolver(internalLogger)
+        previousRunInfoResolver = PreviousRunInfoResolver(internalLogger)
     }
 
     @Test
     fun initLegacyWatcher_whenNoStateFile_returnsNoCrash() {
-        resolver.initLegacyWatcher(tempFolder.root.absolutePath)
+        previousRunInfoResolver.initLegacyWatcher(tempFolder.root.absolutePath)
 
-        val result = resolver.get(activityManager)
+        val result = previousRunInfoResolver.get(activityManager)
 
         assertThat(result).isNull()
     }
@@ -51,8 +53,8 @@ class PreviousRunInfoResolverTest {
     fun get_afterPersistJvmCrashState_returnsCrashOnNextInit() {
         val sdkDir = tempFolder.root.absolutePath
 
-        resolver.initLegacyWatcher(sdkDir)
-        resolver.persistJvmCrashState()
+        previousRunInfoResolver.initLegacyWatcher(sdkDir)
+        previousRunInfoResolver.persistJvmCrashState()
 
         val nextRunResolver = PreviousRunInfoResolver(internalLogger)
         nextRunResolver.initLegacyWatcher(sdkDir)
@@ -67,8 +69,8 @@ class PreviousRunInfoResolverTest {
     fun initLegacyWatcher_resetsStateForCurrentRun() {
         val sdkDir = tempFolder.root.absolutePath
 
-        resolver.initLegacyWatcher(sdkDir)
-        resolver.persistJvmCrashState()
+        previousRunInfoResolver.initLegacyWatcher(sdkDir)
+        previousRunInfoResolver.persistJvmCrashState()
 
         val secondResolver = PreviousRunInfoResolver(internalLogger)
         secondResolver.initLegacyWatcher(sdkDir)
@@ -84,14 +86,14 @@ class PreviousRunInfoResolverTest {
 
     @Test
     fun get_beforeInitLegacyWatcher_returnsNull() {
-        val result = resolver.get(activityManager)
+        val result = previousRunInfoResolver.get(activityManager)
 
         assertThat(result).isNull()
     }
 
     @Test
     fun persistJvmCrashState_beforeInit_logsInternalError() {
-        resolver.persistJvmCrashState()
+        previousRunInfoResolver.persistJvmCrashState()
 
         verify(internalLogger).logInternalError(
             eq(null),
@@ -102,21 +104,51 @@ class PreviousRunInfoResolverTest {
 
     @Test
     @Config(sdk = [30])
-    fun initLegacyWatcher_isNoopOnApi30() {
+    fun initLegacyWatcher_whenApi30_shouldBeNoop() {
         val sdkDir = tempFolder.root.absolutePath
-        resolver.initLegacyWatcher(sdkDir)
+        previousRunInfoResolver.initLegacyWatcher(sdkDir)
 
         assertThat(tempFolder.root.resolve("reports/previous_run_info.state").exists()).isFalse()
     }
 
     @Test
     @Config(sdk = [30])
-    fun persistJvmCrashState_isNoopOnApi30() {
+    fun persistJvmCrashState_whenApi30_shouldBeNoop() {
         val sdkDir = tempFolder.root.absolutePath
-        resolver.initLegacyWatcher(sdkDir)
-        resolver.persistJvmCrashState()
+        previousRunInfoResolver.initLegacyWatcher(sdkDir)
+        previousRunInfoResolver.persistJvmCrashState()
 
         assertThat(tempFolder.root.resolve("reports/previous_run_info.state").exists()).isFalse()
         verify(internalLogger, never()).logInternalError(any(), any(), any())
     }
+
+    @Test
+    @Config(sdk = [30])
+    fun get_onApi30_returnsFatalForCrashReason() {
+        val appExitInfo: ApplicationExitInfo = mock()
+        whenever(appExitInfo.reason).thenReturn(ApplicationExitInfo.REASON_CRASH)
+        val provider = ILatestAppExitInfoProvider { LatestAppExitReasonResult.Valid(appExitInfo) }
+        val api30Resolver = PreviousRunInfoResolver(internalLogger, provider)
+
+        val result = api30Resolver.get(activityManager)
+
+        assertThat(result).isEqualTo(
+            PreviousRunInfo(hasFatallyTerminated = true, reason = ExitReason.JvmCrash),
+        )
+    }
+
+    @Test
+    @Config(sdk = [30])
+    fun get_onApi30_returnsNonFatalForUserRequested() {
+        val appExitInfo: ApplicationExitInfo = mock()
+        whenever(appExitInfo.reason).thenReturn(ApplicationExitInfo.REASON_USER_REQUESTED)
+        val provider = ILatestAppExitInfoProvider { LatestAppExitReasonResult.Valid(appExitInfo) }
+        val api30Resolver = PreviousRunInfoResolver(internalLogger, provider)
+
+        val result = api30Resolver.get(activityManager)
+
+        assertThat(result).isEqualTo(
+            PreviousRunInfo(hasFatallyTerminated = false, reason = ExitReason.UserRequested),
+        )
+    }
 }