Skip to content

Commit 495b5d4

Browse files
authored
Small cleanup (#27)
1 parent e01f08b commit 495b5d4

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

Benchly/ColumnChartExporter.cs

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -166,17 +166,10 @@ private IEnumerable<string> OneParameterCombined(Summary summary)
166166
}).ToList()
167167
}).ToList();
168168

169-
var colors2 = ColorMap.GetColorList(Info);
170-
ColumnChartRenderer.Render(subPlots, title, file, Info.Width, Info.Height, colors2);
169+
var colors = ColorMap.GetColorList(Info);
170+
ColumnChartRenderer.Render(subPlots, title, file, Info.Width, Info.Height, colors);
171171

172172
return new[] { file + ".svg" };
173173
}
174-
175-
// internal measurements are in nanos
176-
// https://github.com/dotnet/BenchmarkDotNet/blob/e4d37d03c0b1ef14e7bde224970bd0fc547fd95a/src/BenchmarkDotNet/Templates/BuildPlots.R#L63-L75
177-
//private static double ConvertNanosToMs(double nanos)
178-
//{
179-
// return nanos * 0.000001;
180-
//}
181174
}
182175
}

Benchly/ColumnChartRenderer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public static void Render(IEnumerable<SubPlot> subPlot, string title, string fil
8383

8484
var annotations = subPlot.Select((p, index) => Annotation.init<double, double, string, string, string, string, string, string, string, string>(
8585
X: xs[index],
86-
Y: -0.1,
86+
Y: 1, // -0.1, bottom breaks layout if the x labels are too long
8787
XAnchor: StyleParam.XAnchorPosition.Center,
8888
ShowArrow: false,
8989
YAnchor: StyleParam.YAnchorPosition.Bottom,

0 commit comments

Comments
 (0)