Fix: add missing unlock in reconnect

Camille Meulien · JacobPlaster · commit 8ba9c3f41c34 · 2020-08-06T11:27:32.000+01:00
diff --git a/v2/websocket/client.go b/v2/websocket/client.go
@@ -329,10 +329,12 @@ func (c *Client) reconnect(socket *Socket, err error) error {
 	c.mtx.RLock()
 	if c.terminal {
 		// dont attempt to reconnect if terminal
+		c.mtx.RUnlock()
 		return err
 	}
 	if !c.parameters.AutoReconnect {
 		err := fmt.Errorf("AutoReconnect setting is disabled, do not reconnect: %s", err.Error())
+		c.mtx.RUnlock()
 		return err
 	}
 	c.mtx.RUnlock()

Original file line number	Diff line number	Diff line change
`@@ -329,10 +329,12 @@ func (c Client) reconnect(socket Socket, err error) error {`
`329`	`329`	`c.mtx.RLock()`
`330`	`330`	`if c.terminal {`
`331`	`331`	`// dont attempt to reconnect if terminal`
	`332`	`+ c.mtx.RUnlock()`
`332`	`333`	`return err`
`333`	`334`	`}`
`334`	`335`	`if !c.parameters.AutoReconnect {`
`335`	`336`	`err := fmt.Errorf("AutoReconnect setting is disabled, do not reconnect: %s", err.Error())`
	`337`	`+ c.mtx.RUnlock()`
`336`	`338`	`return err`
`337`	`339`	`}`
`338`	`340`	`c.mtx.RUnlock()`