Merge pull request #380 from f3rno/fix-trades-payload-event-name

Fix: 'trades' payload event name

Author: f3rno

lib/transports/ws2.js

@@ -682,7 +682,7 @@ class WSv2 extends EventEmitter {
    * @private
    */
   _handleTradeMessage (msg, chanData) {
-    const eventName = msg.length === 3 ? msg[1] : 'trades'
+    const eventName = _isString(msg[1]) ? msg[1] : 'trades'
     let payload = getMessagePayload(msg)
 
     if (!Array.isArray(payload[0])) {

test/lib/transports/ws2-unit.js

@@ -1424,6 +1424,7 @@ describe('WSv2 packet watch-dog', () => {
 
     setTimeout(() => {
       clearInterval(sendInterval)
+      clearTimeout(ws._packetWDTimeout)
       done()
     }, 200)
   })
@@ -1539,3 +1540,25 @@ describe('WSv2 seq audit: _validateMessageSeq', () => {
     assert.equal(ws._validateMessageSeq([0, 'n', nSuccess, 5, 4]), null)
   })
 })
+
+describe('_handleTradeMessage', () => {
+  it('correctly forwards payloads w/ seq numbers', (done) => {
+    const ws = new WSv2()
+    const payload = [
+      [286614318, 1535531325604, 0.05, 7073.51178714],
+      [286614249, 1535531321436, 0.0215938, 7073.6],
+      [286614248, 1535531321430, 0.0284062, 7073.51178714]
+    ]
+    const msg = [1710, payload, 1]
+
+    ws.onTrades({ pair: 'tBTCUSD' }, (data) => {
+      assert.deepStrictEqual(data, payload)
+      done()
+    })
+
+    ws._handleTradeMessage(msg, {
+      channel: 'trades',
+      pair: 'tBTCUSD'
+    })
+  })
+})