Skip to content

Commit 1304465

Browse files
committed
Use SSLContext instead of SSLCertificateSocketFactory
1 parent d0380da commit 1304465

File tree

1 file changed

+14
-16
lines changed

1 file changed

+14
-16
lines changed

lib/src/test/java/at/bitfire/cert4android/CustomCertManagerTest.kt

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,18 @@
1010

1111
package at.bitfire.cert4android
1212

13-
import android.net.SSLCertificateSocketFactory
1413
import org.apache.http.conn.ssl.AllowAllHostnameVerifier
1514
import org.junit.Assume.assumeNotNull
1615
import org.junit.Before
1716
import org.junit.Test
1817
import java.io.IOException
1918
import java.net.URL
19+
import java.security.SecureRandom
2020
import java.security.cert.CertificateException
2121
import java.security.cert.X509Certificate
2222
import javax.net.ssl.HttpsURLConnection
23+
import javax.net.ssl.SSLContext
24+
import javax.net.ssl.TrustManager
2325
import javax.net.ssl.X509TrustManager
2426

2527
class CustomCertManagerTest {
@@ -99,21 +101,17 @@ class CustomCertManagerTest {
99101
val conn = url.openConnection() as HttpsURLConnection
100102
try {
101103
conn.hostnameVerifier = AllowAllHostnameVerifier()
102-
conn.sslSocketFactory = object : SSLCertificateSocketFactory(1000) {
103-
init {
104-
setTrustManagers(arrayOf(object : X509TrustManager {
105-
override fun checkClientTrusted(
106-
chain: Array<out X509Certificate?>?,
107-
authType: String?
108-
) { /* OK */ }
109-
override fun checkServerTrusted(
110-
chain: Array<out X509Certificate?>?,
111-
authType: String?
112-
) { /* OK */ }
113-
override fun getAcceptedIssuers(): Array<out X509Certificate?>? = emptyArray()
114-
}))
115-
}
116-
}
104+
conn.sslSocketFactory = SSLContext.getInstance("TLS").apply {
105+
init(
106+
null,
107+
arrayOf<TrustManager>(object : X509TrustManager {
108+
override fun checkClientTrusted(chain: Array<out X509Certificate>?, authType: String?) {}
109+
override fun checkServerTrusted(chain: Array<out X509Certificate>?, authType: String?) {}
110+
override fun getAcceptedIssuers(): Array<X509Certificate> = emptyArray()
111+
}),
112+
SecureRandom()
113+
)
114+
}.socketFactory
117115
conn.inputStream.read()
118116
val certs = mutableListOf<X509Certificate>()
119117
conn.serverCertificates.forEach { certs += it as X509Certificate }

0 commit comments

Comments
 (0)