Disable logging of digest password (#70)

rfc2822 · web-flow · commit 8691192e2829 · 2025-06-02T11:42:17.000+02:00
diff --git a/src/main/kotlin/at/bitfire/dav4jvm/BasicDigestAuthHandler.kt b/src/main/kotlin/at/bitfire/dav4jvm/BasicDigestAuthHandler.kt
@@ -200,7 +200,8 @@ class BasicDigestAuthHandler(
                 else ->
                     null
             }
-            logger.finer("A1=$a1")
+            // Contains password! Only uncomment for debugging:
+            // logger.finer("A1=$a1")
 
             val a2: String? = when (qop) {
                 Protection.Auth ->
@@ -215,7 +216,7 @@ class BasicDigestAuthHandler(
                     }
                 }
             }
-            logger.finer("A2=$a2")
+            // logger.finer("A2=$a2")
 
             if (a1 != null && a2 != null)
                 response = kd(h(a1), "$nonce:$ncValue:$clientNonce:${qop.qop}:${h(a2)}")

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,8 @@ class BasicDigestAuthHandler(`
`200`	`200`	`else ->`
`201`	`201`	`null`
`202`	`202`	`}`
`203`		`- logger.finer("A1=$a1")`
	`203`	`+ // Contains password! Only uncomment for debugging:`
	`204`	`+ // logger.finer("A1=$a1")`
`204`	`205`
`205`	`206`	`val a2: String? = when (qop) {`
`206`	`207`	`Protection.Auth ->`
`@@ -215,7 +216,7 @@ class BasicDigestAuthHandler(`
`215`	`216`	`}`
`216`	`217`	`}`
`217`	`218`	`}`
`218`		`- logger.finer("A2=$a2")`
	`219`	`+ // logger.finer("A2=$a2")`
`219`	`220`
`220`	`221`	`if (a1 != null && a2 != null)`
`221`	`222`	`response = kd(h(a1), "$nonce:$ncValue:$clientNonce:${qop.qop}:${h(a2)}")`