-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add ktor version and move ktor and okhttp in dedicated packages #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Marked things to check with TODO. Okhttp still present for BasicDigestAuthHandler.
Hi @rfc2822 , The changes do NOT include any refactoring towards KMP. I would do this in a separate step as it require some more extensive refactoring in the parsing part. However, these changes won't necessarily affect other applications using the library anymore as the existing code can stay in the (future) androidMain source set where the package name will be the same. There are minor TODOs left that are mainly meant for a common review, this can also be done at a later stage. |
Cool, I'll have a look. One question: Would it be possible for you to create 2 PRs, one for moving into okhttp and one to create the Ktor package or is that too much effort? It would really help me for reviewing, because I then I can more easily make sure all changes are in the respective package, and the Ktor PR then can't breaking anything in okhttp. |
(But if that would be too cumbersome I can try it as it is.) |
TODO: