Skip to content

Conversation

patrickunterwegs
Copy link
Member

@patrickunterwegs patrickunterwegs commented Aug 1, 2025

TODO:

  • Add note about followRedirects (should be disabled for certain calls)
  • Check or remove AuthHandler

@patrickunterwegs patrickunterwegs self-assigned this Aug 1, 2025
@patrickunterwegs patrickunterwegs added the refactoring Internal improvement of existing functions label Aug 1, 2025
@patrickunterwegs patrickunterwegs marked this pull request as ready for review August 26, 2025 17:56
@patrickunterwegs patrickunterwegs changed the title Replace okhttp with Ktor Add ktor version and move ktor and okhttp in dedicated packages Aug 26, 2025
@patrickunterwegs
Copy link
Member Author

Hi @rfc2822 ,
as discussed I have moved all okhttp and ktor files into dedicated packages. I have tried to keep track of the latest refactoring, this should all be covered. It would be great if you could have a look at this soon and publish a new version with the ktor package included.

The changes do NOT include any refactoring towards KMP. I would do this in a separate step as it require some more extensive refactoring in the parsing part. However, these changes won't necessarily affect other applications using the library anymore as the existing code can stay in the (future) androidMain source set where the package name will be the same. There are minor TODOs left that are mainly meant for a common review, this can also be done at a later stage.

@rfc2822
Copy link
Member

rfc2822 commented Aug 28, 2025

Cool, I'll have a look.

One question: Would it be possible for you to create 2 PRs, one for moving into okhttp and one to create the Ktor package or is that too much effort?

It would really help me for reviewing, because I then I can more easily make sure all changes are in the respective package, and the Ktor PR then can't breaking anything in okhttp.

@rfc2822
Copy link
Member

rfc2822 commented Aug 29, 2025

(But if that would be too cumbersome I can try it as it is.)

@patrickunterwegs
Copy link
Member Author

Hi @rfc2822, I have made #92 for the moving of the code to the okhttp package. I'll update this one as soon as the okhttp one is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants