Add test for PRODID folding (#142)

Author: rfc2822

lib/src/test/kotlin/at/bitfire/synctools/icalendar/Ical4jTest.kt

@@ -8,7 +8,9 @@ package at.bitfire.synctools.icalendar
 
 import at.bitfire.synctools.icalendar.validation.ICalPreprocessor
 import net.fortuna.ical4j.data.CalendarBuilder
+import net.fortuna.ical4j.data.CalendarOutputter
 import net.fortuna.ical4j.data.ParserException
+import net.fortuna.ical4j.model.Calendar
 import net.fortuna.ical4j.model.Component
 import net.fortuna.ical4j.model.DateTime
 import net.fortuna.ical4j.model.Parameter
@@ -20,18 +22,20 @@ import net.fortuna.ical4j.model.component.VEvent
 import net.fortuna.ical4j.model.component.VTimeZone
 import net.fortuna.ical4j.model.parameter.Email
 import net.fortuna.ical4j.model.property.Attendee
+import net.fortuna.ical4j.model.property.ProdId
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotEquals
 import org.junit.Test
 import java.io.StringReader
+import java.io.StringWriter
 import java.time.Period
 
 class Ical4jTest {
 
-    val tzReg = TimeZoneRegistryFactory.getInstance().createRegistry()
+    private val tzReg = TimeZoneRegistryFactory.getInstance().createRegistry()
 
     @Test
-    fun testEmailParameter() {
+    fun `ATTENDEE with EMAIL parameter`() {
         // https://github.com/ical4j/ical4j/issues/418
         val event = ICalendarParser().parse(
             StringReader(
@@ -50,27 +54,77 @@ class Ical4jTest {
     }
 
     @Test
-    fun testTemporalAmountAdapter_durationToString_DropsMinutes() {
+    fun `DTSTART in America_Asuncion from KOrganizer`() {
+        // See https://github.com/bitfireAT/synctools/issues/113
+        val vtzFromKOrganizer = "BEGIN:VCALENDAR\n" +
+                "CALSCALE:GREGORIAN\n" +
+                "VERSION:2.0\n" +
+                "PRODID:-//K Desktop Environment//NONSGML KOrganizer 6.5.0 (25.08.0)//EN\n" +
+                "BEGIN:VTIMEZONE\n" +
+                "TZID:America/Asuncion\n" +
+                "BEGIN:STANDARD\n" +
+                "TZNAME:-03\n" +
+                "TZOFFSETFROM:-0300\n" +
+                "TZOFFSETTO:-0300\n" +
+                "DTSTART:19700101T000000\n" +
+                "END:STANDARD\n" +
+                "END:VTIMEZONE\n" +
+                "BEGIN:VEVENT\n" +
+                "DTSTAMP:20250828T233827Z\n" +
+                "CREATED:20250828T233750Z\n" +
+                "UID:e5d424b9-d3f6-4ee0-bf95-da7537fca1fe\n" +
+                "LAST-MODIFIED:20250828T233827Z\n" +
+                "SUMMARY:Test Timezones\n" +
+                "RRULE:FREQ=WEEKLY;COUNT=3;BYDAY=TH\n" +
+                "DTSTART;TZID=America/Asuncion:20250828T130000\n" +
+                "DTEND;TZID=America/Asuncion:20250828T133000\n" +
+                "TRANSP:OPAQUE\n" +
+                "END:VEVENT\n" +
+                "END:VCALENDAR"
+        val iCalFromKOrganizer = CalendarBuilder().build(StringReader(vtzFromKOrganizer))
+        ICalPreprocessor().preprocessCalendar(iCalFromKOrganizer)
+        val vEvent = iCalFromKOrganizer.getComponent<VEvent>(Component.VEVENT)
+        val dtStart = vEvent.startDate
+        // SHOULD BE UTC -3:
+        // assertEquals(1756396800000, dtStart.date.time)
+        // However is one hour later: 1756400400000
+    }
+
+    @Test
+    fun `PRODID is folded when exactly max line length`() {
+        val calendar = Calendar().apply {
+            properties += ProdId("01234567890123456789012345678901234567890123456789012345678901234567")
+        }
+        val writer = StringWriter()
+        CalendarOutputter().output(calendar, writer)
+        assertEquals("BEGIN:VCALENDAR\r\n" +
+                "PRODID:01234567890123456789012345678901234567890123456789012345678901234567\r\n" +
+                " \r\n" +
+                "END:VCALENDAR\r\n", writer.toString())
+    }
+
+    @Test
+    fun `TemporalAmountAdapter durationToString drops minutes`() {
         // https://github.com/ical4j/ical4j/issues/420
         assertEquals("P1DT1H4M", TemporalAmountAdapter.parse("P1DT1H4M").toString())
     }
 
     @Test(expected = AssertionError::class)
-    fun testTemporalAmountAdapter_Months() {
+    fun `TemporalAmountAdapter months`() {
         // https://github.com/ical4j/ical4j/issues/419
         // A month usually doesn't have 4 weeks = 4*7 days = 28 days (except February in non-leap years).
         assertNotEquals("P4W", TemporalAmountAdapter(Period.ofMonths(1)).toString())
     }
 
     @Test(expected = AssertionError::class)
-    fun testTemporalAmountAdapter_Year() {
+    fun `TemporalAmountAdapter year`() {
         // https://github.com/ical4j/ical4j/issues/419
         // A year has 365 or 366 days, but never 52 weeks = 52*7 days = 364 days.
         assertNotEquals("P52W", TemporalAmountAdapter(Period.ofYears(1)).toString())
     }
 
     @Test(expected = AssertionError::class)
-    fun testTzDarwin() {
+    fun `TZ Darwin`() {
         val darwin = tzReg.getTimeZone("Australia/Darwin")
 
         val ts1 = 1616720400000
@@ -81,7 +135,7 @@ class Ical4jTest {
     }
 
     @Test
-    fun testTzDublin_negativeDst() {
+    fun `TZ Dublin with negative DST`() {
         // https://github.com/ical4j/ical4j/issues/493
         // fixed by enabling net.fortuna.ical4j.timezone.offset.negative_dst_supported in ical4j.properties
         val vtzFromGoogle = "BEGIN:VCALENDAR\n" +
@@ -113,44 +167,7 @@ class Ical4jTest {
     }
 
     @Test
-    fun `DTSTART in America_Asuncion from KOrganizer`() {
-        // See https://github.com/bitfireAT/synctools/issues/113
-        val vtzFromKOrganizer = "BEGIN:VCALENDAR\n" +
-                "CALSCALE:GREGORIAN\n" +
-                "VERSION:2.0\n" +
-                "PRODID:-//K Desktop Environment//NONSGML KOrganizer 6.5.0 (25.08.0)//EN\n" +
-                "BEGIN:VTIMEZONE\n" +
-                "TZID:America/Asuncion\n" +
-                "BEGIN:STANDARD\n" +
-                "TZNAME:-03\n" +
-                "TZOFFSETFROM:-0300\n" +
-                "TZOFFSETTO:-0300\n" +
-                "DTSTART:19700101T000000\n" +
-                "END:STANDARD\n" +
-                "END:VTIMEZONE\n" +
-                "BEGIN:VEVENT\n" +
-                "DTSTAMP:20250828T233827Z\n" +
-                "CREATED:20250828T233750Z\n" +
-                "UID:e5d424b9-d3f6-4ee0-bf95-da7537fca1fe\n" +
-                "LAST-MODIFIED:20250828T233827Z\n" +
-                "SUMMARY:Test Timezones\n" +
-                "RRULE:FREQ=WEEKLY;COUNT=3;BYDAY=TH\n" +
-                "DTSTART;TZID=America/Asuncion:20250828T130000\n" +
-                "DTEND;TZID=America/Asuncion:20250828T133000\n" +
-                "TRANSP:OPAQUE\n" +
-                "END:VEVENT\n" +
-                "END:VCALENDAR"
-        val iCalFromKOrganizer = CalendarBuilder().build(StringReader(vtzFromKOrganizer))
-        ICalPreprocessor().preprocessCalendar(iCalFromKOrganizer)
-        val vEvent = iCalFromKOrganizer.getComponent<VEvent>(Component.VEVENT)
-        val dtStart = vEvent.startDate
-        // SHOULD BE UTC -3:
-        // assertEquals(1756396800000, dtStart.date.time)
-        // However is one hour later: 1756400400000
-    }
-
-    @Test
-    fun testTzKarachi() {
+    fun `TZ Karachi`() {
         // https://github.com/ical4j/ical4j/issues/491
         val karachi = tzReg.getTimeZone("Asia/Karachi")