Update src/handlers/feedback-handler.ts

janikwitzig · Copilot · web-flow · commit c7310136cd7d · 2026-01-10T20:48:04.000+01:00
fix: feedback handler continues to loop if a feedback id is undefined instead of returning

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/src/handlers/feedback-handler.ts b/src/handlers/feedback-handler.ts
@@ -52,7 +52,7 @@ export class FeedbackHandler extends EventEmitter {
 		for (const msg of msgs) {
 			const toUpdate = this.subscriptions?.getFeedbacks(msg.address)
 			if (toUpdate === undefined) {
-				return
+				continue
 			}
 			if (toUpdate.length > 0) {
 				toUpdate.forEach((f) => this.messageFeedbacks.add(f))

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export class FeedbackHandler extends EventEmitter {`
`52`	`52`	`for (const msg of msgs) {`
`53`	`53`	`const toUpdate = this.subscriptions?.getFeedbacks(msg.address)`
`54`	`54`	`if (toUpdate === undefined) {`
`55`		`- return`
	`55`	`+ continue`
`56`	`56`	`}`
`57`	`57`	`if (toUpdate.length > 0) {`
`58`	`58`	`toUpdate.forEach((f) => this.messageFeedbacks.add(f))`