[BUG] Custom Command Property 'Before' - Not working

[jryan324]

Make sure you have updated to the latest version of the module

• I have checked this on the latest version of the module

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

The before property on custom command doesnt work in the latest version of Companion (CompanionPi V4.2.3). See screenshots below.

The dropdown doesnt show text on Macos running companion but technically still works when you guess what button is which. But on CompanionPi, you cant see or select anything in the dropdown.

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS: ComapnionPi
- Browser:Firefox/Safari
- Companion Version:V.4.2.4
- Module Version:2.0.11
- Device Firmware/Software Version (If applicable):
- Device Model (If applicable):RaspberryPi/MacbookPro

Additional context

No response

[NRossmann]

Thanks for the report.

I’ve tested this on my Raspberry Pi 4 running CompanionPi with the latest version of the module, and I’m not able to reproduce the issue. The before property on custom commands behaves as expected for me.

Since this issue is a couple of weeks old and I’m just taking over maintenance of the repository, I’d like to double-check the current state on your side:

Does the issue still occur for you right now?

If so, could you please paste the module logs from the moment you try to set up or edit the button? That should help identify whether this is a UI or module-side problem.

You mentioned that this does not happen when running Companion on your Mac.
Could you let me know which devices and browsers you’ve used to access CompanionPi, and which combinations show the problem (e.g. device + browser)?

Thanks for the detailed report — with the logs and environment details we should be able to narrow this down.

[peternewman]

I'd strongly suggest this is due to/resolved by #59 @NRossmann.

It's probably worth doing a release ASAP as there hasn't been one for two years and some of us have been running the main branch fine for ages.

[NRossmann]

Thank you @peternewman.
I agree a new release is long overdue, and that’s exactly what I’ve been planning to do over the next few days.