v1.1.6 Fix for RealTime messages

Author: MeestorX

README.md

@@ -1,7 +1,7 @@
 # companion-module-generic-midi
 
 A MIDI Module to allow standard MIDI messages to be sent to and received from Companion v3
-v1.1.5
+v1.1.6
 
 Please visit http://discourse.checkcheckonetwo.com for help, discussions, suggestions, etc.
 
@@ -23,6 +23,8 @@ Supported MIDI Commands:
 
 **REVISION HISTORY**
 
+1.1.6 Ignore unsupported commands, bug fix for MTC
+
 1.1.5 Add "Last Message Received" Variable
 
 1.1.4 Ignore Real-Time Messages

companion/HELP.md

@@ -1,4 +1,4 @@
-## Generic MIDI module for Companion - v1.1.5
+## Generic MIDI module for Companion - v1.1.6
 
 Please visit https://discourse.checkcheckonetwo.com for help, discussions, suggestions, etc.
 

companion/manifest.json

@@ -3,7 +3,7 @@
 	"name": "generic-midi",
 	"shortname": "generic-midi",
 	"description": "A generic MIDI module for companion",
-	"version": "1.1.5",
+	"version": "1.1.6",
 	"license": "MIT",
 	"repository": "git+https://github.com/MeestorX/companion-module-generic-midi.git",
 	"bugs": "https://github.com/MeestorX/companion-module-generic-midi/issues",

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "generic-midi",
-	"version": "1.1.5",
+	"version": "1.1.6",
 	"main": "dist/main.js",
 	"type": "module",
 	"scripts": {

src/midi/midi.ts

@@ -13,7 +13,7 @@ export class Input extends EventEmitter {
 	constructor(name: string, virtual?: boolean) {
 		super()
 		this._input = new node_midi.Input()
-		this._input.ignoreTypes(false, true, true) // Allow Sysex but ignore Timing & Active Sense
+		this._input.ignoreTypes(false, false, false) // Allow all message types
 		this._pendingSysex = false
 		this._sysex = []
 		this._smpte = []
@@ -32,11 +32,12 @@ export class Input extends EventEmitter {
 		}
 
 		this._input.on('message', (deltaTime: number, bytes: number[]): void => {
-			// a long sysex can be sent in multiple chunks, depending on the RtMidi buffer size
+			// not dealing with sysex chunks longer than the buffer ATM
 
 			const msg = MidiMessage.parseMessage(bytes)
+			if (msg === undefined) return
 			this.emit('message', deltaTime, msg)
-			if (msg!.id == 'mtc') {
+			if (msg.id == 'mtc') {
 				this.parseMtc(msg as Mtc)
 			}
 		})

src/midi/msgtypes.ts

@@ -136,7 +136,7 @@ export class MidiMessage {
 				incoming = new Mtc(msg.type!, msg.value!)
 				break
 			default:
-				console.log(`Unrecognized MIDI message. Status = ${status}`)
+				console.log(`Unsupported MIDI message. Status = ${hex(status)}`)
 				return
 		}