Add the ability to send raw MDC commands

[peternewman]

To handle new things or features we don't currently support.

[ltuaehome]

What's the correct format for custom commands? Attempting to use hex codes, that I know work with the generic tcp module from companion 3.3, but they don't work through this module. (and thanks for all the work done on this, testing the latest release 2.0.1)

[peternewman]

What's the correct format for custom commands? Attempting to use hex codes, that I know work with the generic tcp module from companion 3.3, but they don't work through this module. (and thanks for all the work done on this, testing the latest release 2.0.1)

Hi @ltuaehome , we're using a library underneath and passing the custom commands into that, which could either be "prettified" commands in the underlying XML config it uses but not yet in Companion, or raw commands via the library. There docs are here:
https://github.com/magik1969/samsung-lfd?tab=readme-ov-file#regular-commands

The key bit being:

NOTE: You can also use MDC commands which are not listed in XML file. In this case use command number, not a name. Parameters (if any) must also be numbers. For hex numbers use 0x prefix. Example: 0x85 80. This sets display max working temperature to 80oC

So you should be able to delete most of the hex codes from your Generic TCP setup as they will be about the ID etc, you'll only need the core message ones (I assume, but haven't yet checked) that it will generate the checksum etc for you.

If you check the module logs (under >_) with verbose turned on in the module config you should find enough info logged to confirm and indeed to see it sending the full command you were sending with Generic TCP before. Do you want to give that a go and let us know how you get on then we can try and improve our docs based on that?

Which command are you trying to send out of interest? Feel free to create a new issue to add support for that one...

[ltuaehome]

HI

@peternewman Thanks for your response, that's just what I needed.

The command I've been trying to get sorted was Manual Lamp (or backlight control)

The key bit you quoted was just the thing. I was trying to send the whole hex command, which was not needed. Just 0x58 followed by 0-100. Being able to dim the backlight rather than mess with the brightness etc is quite useful at times.

Thanks!

[peternewman]

The command I've been trying to get sorted was Manual Lamp (or backlight control)

The key bit you quoted was just the thing. I was trying to send the whole hex command, which was not needed. Just 0x58 followed by 0-100. Being able to dim the backlight rather than mess with the brightness etc is quite useful at times.

There's no reason something like that can't be added to the source library and ultimately the Companion module.

See magik1969/samsung-lfd#6 (comment) for how they need adding to the samsungd.xml file (at which point you can test with the name and value, no hex needed).

Then to add them to the module just needs simple changes like this:
a968f78