Skip to content

Commit f053ada

Browse files
msynkmsynk
committed
resolve review comments
1 parent 41bc41b commit f053ada

File tree

6 files changed

+37
-37
lines changed

6 files changed

+37
-37
lines changed

‎src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ private List<Product> GetExternalIconFaCustoms() =>
9191
[
9292
new() { Type = BitDropdownItemType.Header, Text = "Fruits" },
9393
new() { Text = "Apple", Value = "f-app", Icon = BitIconInfo.Css("fa-solid fa-apple-whole") },
94-
new() { Text = "Banana", Value = "f-ban", Icon = BitIconInfo.Css("fa-solid fa-lemon") },
95-
new() { Text = "Orange", Value = "f-ora", Icon = BitIconInfo.Fa("solid orange"), Disabled = true },
96-
new() { Text = "Grape", Value = "f-gra", Icon = BitIconInfo.Css("fa-solid fa-grapes") },
94+
new() { Text = "Banana", Value = "f-ban", Icon = BitIconInfo.Css("fa-solid fa-moon") },
95+
new() { Text = "Orange", Value = "f-ora", Icon = BitIconInfo.Fa("solid lemon"), Disabled = true },
96+
new() { Text = "Grape", Value = "f-gra", Icon = BitIconInfo.Css("fa-solid fa-droplet") },
9797
new() { Type = BitDropdownItemType.Divider },
9898
new() { Type = BitDropdownItemType.Header, Text = "Vegetables" },
9999
new() { Text = "Broccoli", Value = "v-bro", Icon = BitIconInfo.Css("fa-solid fa-seedling") },
@@ -107,12 +107,12 @@ private List<Product> GetExternalIconBiCustoms() =>
107107
new() { Text = "Apple", Value = "f-app", Icon = BitIconInfo.Bi("apple") },
108108
new() { Text = "Banana", Value = "f-ban", Icon = BitIconInfo.Bi("flower1") },
109109
new() { Text = "Orange", Value = "f-ora", Icon = BitIconInfo.Css("bi bi-sun"), Disabled = true },
110-
new() { Text = "Grape", Value = "f-gra", Icon = BitIconInfo.Bi("grape") },
110+
new() { Text = "Grape", Value = "f-gra", Icon = BitIconInfo.Bi("droplet-fill") },
111111
new() { Type = BitDropdownItemType.Divider },
112112
new() { Type = BitDropdownItemType.Header, Text = "Vegetables" },
113113
new() { Text = "Broccoli", Value = "v-bro", Icon = BitIconInfo.Bi("tree-fill") },
114-
new() { Text = "Carrot", Value = "v-car", Icon = BitIconInfo.Bi("carrot") },
115-
new() { Text = "Lettuce", Value = "v-let", Icon = BitIconInfo.Bi("leaf") }
114+
new() { Text = "Carrot", Value = "v-car", Icon = BitIconInfo.Bi("egg") },
115+
new() { Text = "Lettuce", Value = "v-let", Icon = BitIconInfo.Bi("flower2") }
116116
];
117117

118118
private List<Product> GetRtlCustoms() =>

‎src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1268,9 +1268,9 @@ public class Product
12681268
{
12691269
new() { Text = ""Fruits"", Type = BitDropdownItemType.Header },
12701270
new() { Text = ""Apple"", Value = ""f-app"", Icon = BitIconInfo.Css(""fa-solid fa-apple-whole"") },
1271-
new() { Text = ""Banana"", Value = ""f-ban"", Icon = BitIconInfo.Css(""fa-solid fa-lemon"") },
1272-
new() { Text = ""Orange"", Value = ""f-ora"", Icon = BitIconInfo.Fa(""solid orange""), Disabled = true },
1273-
new() { Text = ""Grape"", Value = ""f-gra"", Icon = BitIconInfo.Css(""fa-solid fa-grapes"") },
1271+
new() { Text = ""Banana"", Value = ""f-ban"", Icon = BitIconInfo.Css(""fa-solid fa-moon"") },
1272+
new() { Text = ""Orange"", Value = ""f-ora"", Icon = BitIconInfo.Fa(""solid lemon""), Disabled = true },
1273+
new() { Text = ""Grape"", Value = ""f-gra"", Icon = BitIconInfo.Css(""fa-solid fa-droplet"") },
12741274
new() { Type = BitDropdownItemType.Divider },
12751275
new() { Text = ""Vegetables"", Type = BitDropdownItemType.Header },
12761276
new() { Text = ""Broccoli"", Value = ""v-bro"", Icon = BitIconInfo.Css(""fa-solid fa-seedling"") },
@@ -1284,12 +1284,12 @@ public class Product
12841284
new() { Text = ""Apple"", Value = ""f-app"", Icon = BitIconInfo.Bi(""apple"") },
12851285
new() { Text = ""Banana"", Value = ""f-ban"", Icon = BitIconInfo.Bi(""flower1"") },
12861286
new() { Text = ""Orange"", Value = ""f-ora"", Icon = BitIconInfo.Css(""bi bi-sun""), Disabled = true },
1287-
new() { Text = ""Grape"", Value = ""f-gra"", Icon = BitIconInfo.Bi(""grape"") },
1287+
new() { Text = ""Grape"", Value = ""f-gra"", Icon = BitIconInfo.Bi(""droplet-fill"") },
12881288
new() { Type = BitDropdownItemType.Divider },
12891289
new() { Text = ""Vegetables"", Type = BitDropdownItemType.Header },
12901290
new() { Text = ""Broccoli"", Value = ""v-bro"", Icon = BitIconInfo.Bi(""tree-fill"") },
1291-
new() { Text = ""Carrot"", Value = ""v-car"", Icon = BitIconInfo.Bi(""carrot"") },
1292-
new() { Text = ""Lettuce"", Value = ""v-let"", Icon = BitIconInfo.Bi(""leaf"") }
1291+
new() { Text = ""Carrot"", Value = ""v-car"", Icon = BitIconInfo.Bi(""egg"") },
1292+
new() { Text = ""Lettuce"", Value = ""v-let"", Icon = BitIconInfo.Bi(""flower2"") }
12931293
};
12941294
12951295
private BitDropdownNameSelectors<Product, string> nameSelectors = new()

‎src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ private List<BitDropdownItem<string>> GetExternalIconFaItems() =>
8484
[
8585
new() { ItemType = BitDropdownItemType.Header, Text = "Fruits" },
8686
new() { Text = "Apple", Value = "f-app", Icon = BitIconInfo.Css("fa-solid fa-apple-whole") },
87-
new() { Text = "Banana", Value = "f-ban", Icon = BitIconInfo.Css("fa-solid fa-lemon") },
88-
new() { Text = "Orange", Value = "f-ora", Icon = BitIconInfo.Fa("solid orange"), IsEnabled = false },
89-
new() { Text = "Grape", Value = "f-gra", Icon = BitIconInfo.Css("fa-solid fa-grapes") },
87+
new() { Text = "Banana", Value = "f-ban", Icon = BitIconInfo.Css("fa-solid fa-moon") },
88+
new() { Text = "Orange", Value = "f-ora", Icon = BitIconInfo.Fa("solid lemon"), IsEnabled = false },
89+
new() { Text = "Grape", Value = "f-gra", Icon = BitIconInfo.Css("fa-solid fa-droplet") },
9090
new() { ItemType = BitDropdownItemType.Divider },
9191
new() { ItemType = BitDropdownItemType.Header, Text = "Vegetables" },
9292
new() { Text = "Broccoli", Value = "v-bro", Icon = BitIconInfo.Css("fa-solid fa-seedling") },
@@ -100,12 +100,12 @@ private List<BitDropdownItem<string>> GetExternalIconBiItems() =>
100100
new() { Text = "Apple", Value = "f-app", Icon = BitIconInfo.Bi("apple") },
101101
new() { Text = "Banana", Value = "f-ban", Icon = BitIconInfo.Bi("flower1") },
102102
new() { Text = "Orange", Value = "f-ora", Icon = BitIconInfo.Css("bi bi-sun"), IsEnabled = false },
103-
new() { Text = "Grape", Value = "f-gra", Icon = BitIconInfo.Bi("grape") },
103+
new() { Text = "Grape", Value = "f-gra", Icon = BitIconInfo.Bi("droplet-fill") },
104104
new() { ItemType = BitDropdownItemType.Divider },
105105
new() { ItemType = BitDropdownItemType.Header, Text = "Vegetables" },
106106
new() { Text = "Broccoli", Value = "v-bro", Icon = BitIconInfo.Bi("tree-fill") },
107-
new() { Text = "Carrot", Value = "v-car", Icon = BitIconInfo.Bi("carrot") },
108-
new() { Text = "Lettuce", Value = "v-let", Icon = BitIconInfo.Bi("leaf") }
107+
new() { Text = "Carrot", Value = "v-car", Icon = BitIconInfo.Bi("egg") },
108+
new() { Text = "Lettuce", Value = "v-let", Icon = BitIconInfo.Bi("flower2") }
109109
];
110110

111111
private List<BitDropdownItem<string>> comboBoxItems =

‎src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -853,9 +853,9 @@ Combo Chips Dynamic
853853
{
854854
new() { ItemType = BitDropdownItemType.Header, Text = ""Fruits"" },
855855
new() { Text = ""Apple"", Value = ""f-app"", Icon = BitIconInfo.Css(""fa-solid fa-apple-whole"") },
856-
new() { Text = ""Banana"", Value = ""f-ban"", Icon = BitIconInfo.Css(""fa-solid fa-lemon"") },
857-
new() { Text = ""Orange"", Value = ""f-ora"", Icon = BitIconInfo.Fa(""solid orange""), IsEnabled = false },
858-
new() { Text = ""Grape"", Value = ""f-gra"", Icon = BitIconInfo.Css(""fa-solid fa-grapes"") },
856+
new() { Text = ""Banana"", Value = ""f-ban"", Icon = BitIconInfo.Css(""fa-solid fa-moon"") },
857+
new() { Text = ""Orange"", Value = ""f-ora"", Icon = BitIconInfo.Fa(""solid lemon""), IsEnabled = false },
858+
new() { Text = ""Grape"", Value = ""f-gra"", Icon = BitIconInfo.Css(""fa-solid fa-droplet"") },
859859
new() { ItemType = BitDropdownItemType.Divider },
860860
new() { ItemType = BitDropdownItemType.Header, Text = ""Vegetables"" },
861861
new() { Text = ""Broccoli"", Value = ""v-bro"", Icon = BitIconInfo.Css(""fa-solid fa-seedling"") },
@@ -869,12 +869,12 @@ Combo Chips Dynamic
869869
new() { Text = ""Apple"", Value = ""f-app"", Icon = BitIconInfo.Bi(""apple"") },
870870
new() { Text = ""Banana"", Value = ""f-ban"", Icon = BitIconInfo.Bi(""flower1"") },
871871
new() { Text = ""Orange"", Value = ""f-ora"", Icon = BitIconInfo.Css(""bi bi-sun""), IsEnabled = false },
872-
new() { Text = ""Grape"", Value = ""f-gra"", Icon = BitIconInfo.Bi(""grape"") },
872+
new() { Text = ""Grape"", Value = ""f-gra"", Icon = BitIconInfo.Bi(""droplet-fill"") },
873873
new() { ItemType = BitDropdownItemType.Divider },
874874
new() { ItemType = BitDropdownItemType.Header, Text = ""Vegetables"" },
875875
new() { Text = ""Broccoli"", Value = ""v-bro"", Icon = BitIconInfo.Bi(""tree-fill"") },
876-
new() { Text = ""Carrot"", Value = ""v-car"", Icon = BitIconInfo.Bi(""carrot"") },
877-
new() { Text = ""Lettuce"", Value = ""v-let"", Icon = BitIconInfo.Bi(""leaf"") }
876+
new() { Text = ""Carrot"", Value = ""v-car"", Icon = BitIconInfo.Bi(""egg"") },
877+
new() { Text = ""Lettuce"", Value = ""v-let"", Icon = BitIconInfo.Bi(""flower2"") }
878878
};";
879879

880880
private readonly string example16RazorCode = @"

‎src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -713,9 +713,9 @@
713713
TItem="BitDropdownOption<string>" TValue="string">
714714
<BitDropdownOption ItemType="BitDropdownItemType.Header" Text="Fruits" Value="@string.Empty" />
715715
<BitDropdownOption Text="Apple" Value="@("f-app")" Icon="@BitIconInfo.Css("fa-solid fa-apple-whole")" />
716-
<BitDropdownOption Text="Banana" Value="@("f-ban")" Icon="@BitIconInfo.Css("fa-solid fa-lemon")" />
717-
<BitDropdownOption Text="Orange" Value="@("f-ora")" Icon="@BitIconInfo.Fa("solid orange")" IsEnabled="false" />
718-
<BitDropdownOption Text="Grape" Value="@("f-gra")" Icon="@BitIconInfo.Css("fa-solid fa-grapes")" />
716+
<BitDropdownOption Text="Banana" Value="@("f-ban")" Icon="@BitIconInfo.Css("fa-solid fa-moon")" />
717+
<BitDropdownOption Text="Orange" Value="@("f-ora")" Icon="@BitIconInfo.Fa("solid lemon")" IsEnabled="false" />
718+
<BitDropdownOption Text="Grape" Value="@("f-gra")" Icon="@BitIconInfo.Css("fa-solid fa-droplet")" />
719719
<BitDropdownOption ItemType="BitDropdownItemType.Divider" Value="@string.Empty" />
720720
<BitDropdownOption ItemType="BitDropdownItemType.Header" Text="Vegetables" Value="@string.Empty" />
721721
<BitDropdownOption Text="Broccoli" Value="@("v-bro")" Icon="@BitIconInfo.Css("fa-solid fa-seedling")" />
@@ -730,12 +730,12 @@
730730
<BitDropdownOption Text="Apple" Value="@("f-app")" Icon="@BitIconInfo.Bi("apple")" />
731731
<BitDropdownOption Text="Banana" Value="@("f-ban")" Icon="@BitIconInfo.Bi("flower1")" />
732732
<BitDropdownOption Text="Orange" Value="@("f-ora")" Icon="@BitIconInfo.Css("bi bi-sun")" IsEnabled="false" />
733-
<BitDropdownOption Text="Grape" Value="@("f-gra")" Icon="@BitIconInfo.Bi("grape")" />
733+
<BitDropdownOption Text="Grape" Value="@("f-gra")" Icon="@BitIconInfo.Bi("droplet-fill")" />
734734
<BitDropdownOption ItemType="BitDropdownItemType.Divider" Value="@string.Empty" />
735735
<BitDropdownOption ItemType="BitDropdownItemType.Header" Text="Vegetables" Value="@string.Empty" />
736736
<BitDropdownOption Text="Broccoli" Value="@("v-bro")" Icon="@BitIconInfo.Bi("tree-fill")" />
737-
<BitDropdownOption Text="Carrot" Value="@("v-car")" Icon="@BitIconInfo.Bi("carrot")" />
738-
<BitDropdownOption Text="Lettuce" Value="@("v-let")" Icon="@BitIconInfo.Bi("leaf")" />
737+
<BitDropdownOption Text="Carrot" Value="@("v-car")" Icon="@BitIconInfo.Bi("egg")" />
738+
<BitDropdownOption Text="Lettuce" Value="@("v-let")" Icon="@BitIconInfo.Bi("flower2")" />
739739
</BitDropdown>
740740
</div>
741741
</DemoExample>

‎src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
namespace Bit.BlazorUI.Demo.Client.Core.Pages.Components.Inputs.Dropdown;
1+
namespace Bit.BlazorUI.Demo.Client.Core.Pages.Components.Inputs.Dropdown;
22

33
public partial class _BitDropdownOptionDemo
44
{
@@ -882,9 +882,9 @@ private void HandleOnDynamicAdd(BitDropdownOption<string> item)
882882
TItem=""BitDropdownOption<string>"" TValue=""string"">
883883
<BitDropdownOption ItemType=""BitDropdownItemType.Header"" Text=""Fruits"" Value=""@string.Empty"" />
884884
<BitDropdownOption Text=""Apple"" Value=""@(""f-app"")"" Icon=""@BitIconInfo.Css(""fa-solid fa-apple-whole"")"" />
885-
<BitDropdownOption Text=""Banana"" Value=""@(""f-ban"")"" Icon=""@BitIconInfo.Css(""fa-solid fa-lemon"")"" />
886-
<BitDropdownOption Text=""Orange"" Value=""@(""f-ora"")"" Icon=""@BitIconInfo.Fa(""solid orange"")"" IsEnabled=""false"" />
887-
<BitDropdownOption Text=""Grape"" Value=""@(""f-gra"")"" Icon=""@BitIconInfo.Css(""fa-solid fa-grapes"")"" />
885+
<BitDropdownOption Text=""Banana"" Value=""@(""f-ban"")"" Icon=""@BitIconInfo.Css(""fa-solid fa-moon"")"" />
886+
<BitDropdownOption Text=""Orange"" Value=""@(""f-ora"")"" Icon=""@BitIconInfo.Fa(""solid lemon"")"" IsEnabled=""false"" />
887+
<BitDropdownOption Text=""Grape"" Value=""@(""f-gra"")"" Icon=""@BitIconInfo.Css(""fa-solid fa-droplet"")"" />
888888
<BitDropdownOption ItemType=""BitDropdownItemType.Divider"" Value=""@string.Empty"" />
889889
<BitDropdownOption ItemType=""BitDropdownItemType.Header"" Text=""Vegetables"" Value=""@string.Empty"" />
890890
<BitDropdownOption Text=""Broccoli"" Value=""@(""v-bro"")"" Icon=""@BitIconInfo.Css(""fa-solid fa-seedling"")"" />
@@ -899,12 +899,12 @@ private void HandleOnDynamicAdd(BitDropdownOption<string> item)
899899
<BitDropdownOption Text=""Apple"" Value=""@(""f-app"")"" Icon=""@BitIconInfo.Bi(""apple"")"" />
900900
<BitDropdownOption Text=""Banana"" Value=""@(""f-ban"")"" Icon=""@BitIconInfo.Bi(""flower1"")"" />
901901
<BitDropdownOption Text=""Orange"" Value=""@(""f-ora"")"" Icon=""@BitIconInfo.Css(""bi bi-sun"")"" IsEnabled=""false"" />
902-
<BitDropdownOption Text=""Grape"" Value=""@(""f-gra"")"" Icon=""@BitIconInfo.Bi(""grape"")"" />
902+
<BitDropdownOption Text=""Grape"" Value=""@(""f-gra"")"" Icon=""@BitIconInfo.Bi(""droplet-fill"")"" />
903903
<BitDropdownOption ItemType=""BitDropdownItemType.Divider"" Value=""@string.Empty"" />
904904
<BitDropdownOption ItemType=""BitDropdownItemType.Header"" Text=""Vegetables"" Value=""@string.Empty"" />
905905
<BitDropdownOption Text=""Broccoli"" Value=""@(""v-bro"")"" Icon=""@BitIconInfo.Bi(""tree-fill"")"" />
906-
<BitDropdownOption Text=""Carrot"" Value=""@(""v-car"")"" Icon=""@BitIconInfo.Bi(""carrot"")"" />
907-
<BitDropdownOption Text=""Lettuce"" Value=""@(""v-let"")"" Icon=""@BitIconInfo.Bi(""leaf"")"" />
906+
<BitDropdownOption Text=""Carrot"" Value=""@(""v-car"")"" Icon=""@BitIconInfo.Bi(""egg"")"" />
907+
<BitDropdownOption Text=""Lettuce"" Value=""@(""v-let"")"" Icon=""@BitIconInfo.Bi(""flower2"")"" />
908908
</BitDropdown>";
909909
private readonly string example15CsharpCode = @"
910910
private readonly List<BitDropdownItem<string>> basicItems =

0 commit comments

Comments
 (0)