Skip to content

Commit 556b4ce

Browse files
committed
added enum for statistics interval added tests showing how to use it
1 parent f9618ea commit 556b4ce

File tree

4 files changed

+30
-4
lines changed

4 files changed

+30
-4
lines changed

bitmovin/analytics/statistics.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ export const statistics = (configuration, http) => {
2424

2525
const url = urljoin(analyticsStatisticsBaseUrl, getParams);
2626
return get(configuration, url);
27+
},
28+
INTERVAL: {
29+
DAILY: 'DAILY'
2730
}
2831
};
2932
};

bitmovin/player/statistics.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ export const statistics = (configuration, http) => {
2424

2525
const url = urljoin(playerStatisticsBaseUrl, getParams);
2626
return get(configuration, url);
27+
},
28+
INTERVAL: {
29+
DAILY: 'DAILY'
2730
}
2831
};
2932
};

tests/analytics/statistics.test.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,18 @@ describe('analytics', () => {
1717

1818
describe('statistics', () => {
1919
describe('impressions', () => {
20-
assertItCallsCorrectUrl('GET', '/v1/analytics/statistics/impressions', statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02'));
21-
assertItReturnsUnderlyingPromise(mockGet, statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02'));
20+
describe('impressions default interval', () => {
21+
assertItCallsCorrectUrl('GET', '/v1/analytics/statistics/impressions',
22+
statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02'));
23+
assertItReturnsUnderlyingPromise(mockGet,
24+
statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02'));
25+
});
26+
describe('impressions daily interval', () => {
27+
assertItCallsCorrectUrl('GET', '/v1/analytics/statistics/impressions',
28+
statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02', statisticsClient.INTERVAL.DAILY));
29+
assertItReturnsUnderlyingPromise(mockGet,
30+
statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02', statisticsClient.INTERVAL.DAILY));
31+
});
2232
});
2333
});
2434
});

tests/player/statistics.test.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,18 @@ describe('player', () => {
1717

1818
describe('statistics', () => {
1919
describe('impressions', () => {
20-
assertItCallsCorrectUrl('GET', '/v1/player/statistics/impressions', statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02'));
21-
assertItReturnsUnderlyingPromise(mockGet, statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02'));
20+
describe('impressions default interval', () => {
21+
assertItCallsCorrectUrl('GET', '/v1/player/statistics/impressions',
22+
statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02'));
23+
assertItReturnsUnderlyingPromise(mockGet,
24+
statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02'));
25+
});
26+
describe('impressions daily interval', () => {
27+
assertItCallsCorrectUrl('GET', '/v1/player/statistics/impressions',
28+
statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02', statisticsClient.INTERVAL.DAILY));
29+
assertItReturnsUnderlyingPromise(mockGet,
30+
statisticsClient.impressions.bind(this, 'asdf', '2017-01-01', '2017-01-02', statisticsClient.INTERVAL.DAILY));
31+
});
2232
});
2333
});
2434
});

0 commit comments

Comments
 (0)