[bitnami/thanos] Sharded storegateway endpoints always use dnssrv+ prefix regardless of dnsDiscovery setting

[parthivrmenon]

Name and Version

bitnami/thanos 17.3.3

What steps will reproduce the bug?

1. Configure Thanos with sharded storegateways and DNS discovery disabled in values.yaml:

   • Set query.dnsDiscovery.enabled: false
   • Set storegateway.enabled: true
   • Set storegateway.sharded.enabled: true
   • Configure storegateway.sharded.timePartitioning with multiple time ranges

2. Render the query deployment template:
   helm template my-thanos bitnami/thanos --version 17.3.3 --values values.yaml --show-only templates/query/deployment.yaml

3. Inspect the generated --endpoint flags in the query container args section

4. Observe that all endpoint flags include the dnssrv+_grpc._tcp. prefix despite DNS discovery being disabled

Are you using any custom parameters or values?

No response

What is the expected behavior?

When query.dnsDiscovery.enabled is set to false, the query deployment should generate plain endpoint URLs without the dnssrv+ prefix for sharded storegateways, similar to how non-sharded storegateways are handled.

Expected output in the rendered template:

• --endpoint=my-thanos-storegateway-0.default.svc.cluster.local:10901
• --endpoint=my-thanos-storegateway-1.default.svc.cluster.local:10901
• --endpoint=my-thanos-storegateway-2.default.svc.cluster.local:10901

The dnsDiscovery.enabled setting should be respected consistently for both sharded and non-sharded storegateway configurations.

What do you see instead?

The template always generates endpoint flags with the dnssrv+_grpc._tcp. prefix for sharded storegateways, regardless of the query.dnsDiscovery.enabled setting.

Actual output in the rendered template:

• --endpoint=dnssrv+_grpc._tcp.my-thanos-storegateway-0.default.svc.cluster.local
• --endpoint=dnssrv+_grpc._tcp.my-thanos-storegateway-1.default.svc.cluster.local
• --endpoint=dnssrv+_grpc._tcp.my-thanos-storegateway-2.default.svc.cluster.local

The DNS discovery setting is being ignored for sharded storegateways, even though it is correctly respected for non-sharded storegateways.

Additional information

No response

[github-actions]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[alvneiayu]

thanks a lot for sending us a PR @parthivrmenon.