Custom modifiers is not works

[gialloguitar]

Hi!
Im trying to follow README to declare a new types of modifiers like this:

...
  "modifiers": {
    "array": "array",
    "object": "object",
    "string": "string",
    "nullable": "nullable",
    "default": "default",
    "boolean": "boolean",
    "number": "number",
    "integer": "integer"
  },
...

My test chart values is:

## @param enabled [boolean, nullable] Desc
enabled: false

Run:
readme-generator-for-helm -c config.json -r tmp/README.md -v tmp/values.yaml -s tmp/values.schema.json

and I've got an error:

INFO: Checking missing metadata...
INFO: Metadata is correct!
/snapshot/helm-readme-generator/lib/builder.js:53
        throw new Error(`Unknown modifier: ${modifier} for parameter ${param.name}`);
        ^

Error: Unknown modifier: boolean for parameter enabled
    at /snapshot/helm-readme-generator/lib/builder.js:53:15
    at Array.forEach (<anonymous>)
    at applyModifiers (/snapshot/helm-readme-generator/lib/builder.js:22:19)
    at buildParamsToRenderList (/snapshot/helm-readme-generator/lib/builder.js:109:7)
    at /snapshot/helm-readme-generator/index.js:53:30
    at Array.forEach (<anonymous>)
    at runReadmeGenerator (/snapshot/helm-readme-generator/index.js:52:31)
    at Object.<anonymous> (/snapshot/helm-readme-generator/bin/index.js:22:1)
    at Module._compile (pkg/prelude/bootstrap.js:1926:22)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)

NOTE: If use values like this:

...
## @param enabled Desc
enabled: false

,then the boolean type will be success detected in JSON schema. But I need to work with nullable values, but custom modifires not works as expected.

My version of package is 2.7.2

Btw, looks like custom modifiers doesn't support here, but I can mistake.

Thank you!

[GBHU753]

I'm getting the same error with:

## @param enabled [boolean] Desc
enabled: false

[fmulero]

Hi, thanks for using bitnami/readme-generator-for-helm

As @gialloguitar spotted, this feature seems not supported.

I've just opened a PR #176 supporting the boolean modifier, please note that this type does not support the null value. Could please review it? Does it cover your needs?

[GBHU753]

This looks good from my end. On a related note, should we add number as a modifier as well since it was previously in the readme.

[gialloguitar]

Hi, @fmulero thanks for you attention!

Yes, that’s a good and rather debatable question regarding JSON Schema and default values for numbers and booleans.
For example, when I explicitly write replicas: 1 or enabled: false, the generated JSON schema correctly infers their types as integer and boolean, respectively. And it seems that custom modifiers aren’t needed in that case at all.

But when are they actually needed?
For instance, when I don’t want to explicitly specify replicas in values.yaml and prefer to set this field in the template only if it’s explicitly defined - that’s when the question arises: what default value will JSON Schema assign in that case?
Ideally, it would be nil, but that would clearly cause a type mismatch error.

Thus, I expect support for multiple types for values, like that (but it's not work now):

## @param replicas [number, nullable]
replicas:

I would like expect in JSON schema:

"type": ["number", "null"] 

And the similar behavior with boolean type (but default False is suitable enough)