Skip to content

Commit 5950e5e

Browse files
authored
Update README.md
1 parent 6a6eafe commit 5950e5e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ Define `aws_spa_root_object` if different than `index.html`
1818
You'll need [Access Keys](https://docs.aws.amazon.com/powershell/latest/userguide/pstools-appendix-sign-up.html) from an [AWS account](https://aws.amazon.com/premiumsupport/knowledge-center/create-and-activate-aws-account/)
1919

2020
### 3. CERTIFICATES - Only for AWS Managed domains with Route53
21-
If `domain_name` is defined, we will look up for a certificate with the name of that domain (eg. `example.com`). We expect that certificate to contain both `example.com` and `*.example.com`.
21+
If `aws_r53_domain_name` is defined, we will look up for a certificate with the name of that domain (eg. `example.com`). We expect that certificate to contain both `example.com` and `*.example.com`.
2222

23-
Setting `create_root_cert` to `true` will create this certificate with both `example.com` and `*.example.com` for you, and validate them. (DNS validation).
23+
Setting `aws_r53_create_root_cert` to `true` will create this certificate with both `example.com` and `*.example.com` for you, and validate them. (DNS validation).
2424

25-
Setting `create_sub_cert` to `true` will create a certificate **just for the subdomain**, and validate it.
25+
Setting `aws_r53_create_sub_cert` to `true` will create a certificate **just for the subdomain**, and validate it.
2626

2727
> :warning: Be very careful here! **Created certificates are fully managed by Terraform**. Therefor **they will be destroyed upon stack destruction**.
2828
@@ -43,7 +43,7 @@ jobs:
4343
runs-on: ubuntu-latest
4444

4545
steps:
46-
- name: Create deploy-bucket-only
46+
- name: Create deploy-bucket
4747
uses: bitovi/[email protected]
4848
with:
4949
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID_SANDBOX}}
@@ -55,7 +55,8 @@ jobs:
5555

5656
aws_spa_cdn_enabled: true
5757

58-
aws_r53_domain_name: examplex.com
58+
# You should own and have this domain available
59+
aws_r53_domain_name: example.com
5960
aws_r53_sub_domain_name: spa
6061
```
6162

0 commit comments

Comments
 (0)