Skip to content

Commit 62c7072

Browse files
authored
Merge pull request #178 from bobbrodie/SP-260
SP-260 Update tests for date de/serialization and run tests on pull requests
2 parents 6f1b7c9 + fdb0bbb commit 62c7072

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
name: Build
22

33
on:
4+
pull_request:
5+
types:
6+
- opened
7+
- reopened
48
push:
59
branches-ignore:
610
- 'master'

pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,9 @@
127127
<groupId>org.apache.maven.plugins</groupId>
128128
<artifactId>maven-surefire-plugin</artifactId>
129129
<version>2.22.2</version>
130+
<configuration>
131+
<argLine>-Duser.timezone=UTC</argLine>
132+
</configuration>
130133
</plugin>
131134
</plugins>
132135
</build>

src/test/java/com/bitpay/sdk/util/DateDeserializerTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ public class DateDeserializerTest {
1616
@Test
1717
public void it_should_deserialize_date() throws IOException {
1818
// given
19-
System.setProperty("user.timezone", "UTC");
2019
DateDeserializer testedClass = new DateDeserializer();
2120
JsonParser jsonParser = Mockito.mock(JsonParser.class);
2221
DeserializationContext deserializationContext = Mockito.mock(DeserializationContext.class);

src/test/java/com/bitpay/sdk/util/DateSerializerTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public class DateSerializerTest {
1515
@Test
1616
public void it_should_serialize_date() throws IOException {
1717
// given
18-
System.setProperty("user.timezone", "UTC");
1918
DateSerializer testedClass = new DateSerializer();
2019
JsonGenerator jsonGenerator = Mockito.mock(JsonGenerator.class);
2120
SerializerProvider serializerProvider = Mockito.mock(SerializerProvider.class);

0 commit comments

Comments
 (0)