Improve create clients

Author: mwarzybok-sumoheavy

src/main/java/com/bitpay/sdk/model/Invoice/RefundInfo.java

@@ -24,7 +24,6 @@ public class RefundInfo {
 
     private String supportRequest = DEFAULT_NON_SENT_VALUE;
     private String currency = DEFAULT_NON_SENT_VALUE;
-    private String refundRequestEid = DEFAULT_NON_SENT_VALUE;
     private Hashtable<String, Double> amounts;
 
     /**
@@ -79,25 +78,6 @@ public void setCurrency(String currency) throws BitPayException {
         this.currency = currency;
     }
 
-    /**
-     * Gets Refund Request Eid.
-     *
-     * @return Refund Request Eid
-     */
-    @JsonInclude(JsonInclude.Include.NON_DEFAULT)
-    public String getRefundRequestEid() {
-        return this.refundRequestEid;
-    }
-
-    /**
-     * Sets Refund Request Eid.
-     *
-     * @param refundRequestEid Refund Request Eid
-     */
-    public void setRefundRequestEid(String refundRequestEid) {
-        this.refundRequestEid = refundRequestEid;
-    }
-
     /**
      * Gets amounts. For a refunded invoice, this object will contain the crypto currency amount refunded by BitPay
      * to the consumer (in the selected transactionCurrency) and the equivalent refunded amount from the invoice

src/main/java/com/bitpay/sdk/model/Settlement/InvoiceData.java

@@ -25,7 +25,6 @@ public class InvoiceData {
     private String transactionCurrency;
     private Float overPaidAmount;
     private Map<String, Double> payoutPercentage;
-    private Float btcPrice;
     private RefundInfo refundInfo;
 
     /**
@@ -181,26 +180,6 @@ public void setPayoutPercentage(Map<String, Double> payoutPercentage) {
         this.payoutPercentage = payoutPercentage;
     }
 
-    /**
-     * Gets btc price.
-     *
-     * @return the btc price
-     */
-    @JsonIgnore
-    public Float getBtcPrice() {
-        return this.btcPrice;
-    }
-
-    /**
-     * Sets btc price.
-     *
-     * @param btcPrice the btc price
-     */
-    @JsonProperty("btcPrice")
-    public void setBtcPrice(Float btcPrice) {
-        this.btcPrice = btcPrice;
-    }
-
     /**
      * Gets amount.
      *

src/main/java/com/bitpay/sdk/model/Settlement/RefundInfo.java

@@ -19,8 +19,6 @@ public class RefundInfo {
     private String supportRequest;
     private String currency;
     private Hashtable<String, Double> amounts;
-    private String reference;
-    private String refundRequestEid;
 
     /**
      * Instantiates a new Refund info.
@@ -91,48 +89,4 @@ public Hashtable<String, Double> getAmount() {
     public void setAmount(Hashtable<String, Double> amounts) {
         this.amounts = amounts;
     }
-
-    /**
-     * Gets reference. Present only if specified in the request to create the refund.
-     * This is your reference label for this refund.
-     * It will be passed-through on each response for you to identify the refund in your system.
-     * Maximum string length is 100 characters.
-     *
-     * @return the reference
-     */
-    @JsonIgnore
-    public String getReference() {
-        return this.reference;
-    }
-
-    /**
-     * Sets reference. Present only if specified in the request to create the refund.
-     * This is your reference label for this refund.
-     * It will be passed-through on each response for you to identify the refund in your system.
-     * Maximum string length is 100 characters.
-     *
-     * @param reference the reference
-     */
-    @JsonProperty("reference")
-    public void setReference(String reference) {
-        this.reference = reference;
-    }
-
-    /**
-     * Gets Refund Request Eid.
-     *
-     * @return Refund Request Eid
-     */
-    public String getRefundRequestEid() {
-        return this.refundRequestEid;
-    }
-
-    /**
-     * Sets Refund Request Eid.
-     *
-     * @param refundRequestEid Refund Request Eid
-     */
-    public void setRefundRequestEid(String refundRequestEid) {
-        this.refundRequestEid = refundRequestEid;
-    }
 }

src/test/java/com/bitpay/sdk/model/Invoice/RefundInfoTest.java

@@ -37,19 +37,6 @@ public void it_should_manipulate_currency() throws BitPayException {
         Assertions.assertEquals(expected, testedClass.getCurrency());
     }
 
-    @Test
-    public void it_should_manipulate_refundRequestEid() {
-        // given
-        String expected = "someString";
-        RefundInfo testedClass = this.getTestedClass();
-
-        // when
-        testedClass.setRefundRequestEid(expected);
-
-        // then
-        Assertions.assertEquals(expected, testedClass.getRefundRequestEid());
-    }
-
     @Test
     public void it_should_not_allow_to_set_invalid_currency() {
         Assertions.assertThrows(BitPayException.class, () -> {

src/test/java/com/bitpay/sdk/model/Ledger/LedgerEntryTest.java

@@ -76,6 +76,7 @@ public void it_should_change_timestamp() {
     }
 
     @Test
+    @SuppressWarnings("deprecation")
     public void it_should_change_txType() {
         // given
         String expected = "expectedString";

src/test/java/com/bitpay/sdk/model/Settlement/InvoiceDataTest.java

@@ -103,19 +103,6 @@ public void it_should_change_payoutPercentage() {
         Assertions.assertEquals(expected, testedClass.getPayoutPercentage());
     }
 
-    @Test
-    public void it_should_change_btcPrice() {
-        // given
-        Float expected = 12.34F;
-        InvoiceData testedClass = this.getTestedClass();
-
-        // when
-        testedClass.setBtcPrice(expected);
-
-        // then
-        Assertions.assertEquals(expected, testedClass.getBtcPrice());
-    }
-
     @Test
     public void it_should_change_refundInfo() {
         // given

src/test/java/com/bitpay/sdk/model/Settlement/RefundInfoTest.java

@@ -49,32 +49,6 @@ public void it_should_change_amounts() {
         Assertions.assertSame(expected, testedClass.getAmount());
     }
 
-    @Test
-    public void it_should_change_reference() {
-        // given
-        String expected = "expectedString";
-        RefundInfo testedClass = this.getTestedClass();
-
-        // when
-        testedClass.setReference(expected);
-
-        // then
-        Assertions.assertEquals(expected, testedClass.getReference());
-    }
-
-    @Test
-    public void it_should_manipulate_refundRequestEid() {
-        // given
-        String expected = "someString";
-        RefundInfo testedClass = this.getTestedClass();
-
-        // when
-        testedClass.setRefundRequestEid(expected);
-
-        // then
-        Assertions.assertEquals(expected, testedClass.getRefundRequestEid());
-    }
-
     private RefundInfo getTestedClass() {
         return new RefundInfo();
     }