Add test for runtime error

Author: AMecea

pkg/apis/mysql/v1alpha1/mysqlcluster_defaults.go

@@ -31,7 +31,11 @@ var (
 	resourceRequestMemory = resource.MustParse("1Gi")
 )
 
-// SetDefaults_MysqlCluster sets the defaults for a mysqlcluster object
+var (
+	one int32 = 1
+)
+
+// SetDefaults_MysqlCluster sets the defaults for a MySQLCLuster object
 // nolint
 func SetDefaults_MysqlCluster(c *MysqlCluster) {
 
@@ -42,7 +46,6 @@ func SetDefaults_MysqlCluster(c *MysqlCluster) {
 	}
 
 	if c.Spec.Replicas == nil {
-		one := int32(1)
 		c.Spec.Replicas = &one
 	}
 
@@ -53,7 +56,6 @@ func SetDefaults_MysqlCluster(c *MysqlCluster) {
 	if len(c.Spec.MinAvailable) == 0 && *c.Spec.Replicas > 1 {
 		c.Spec.MinAvailable = defaultMinAvailable
 	}
-
 }
 
 // SetDefaults for PodSpec
@@ -66,7 +68,6 @@ func (c *MysqlCluster) setPodSpecDefaults(spec *PodSpec) {
 			},
 		}
 	}
-
 }
 
 // SetDefaults for VolumeSpec

pkg/apis/mysql/v1alpha1/mysqlcluster_types_test.go

@@ -19,7 +19,6 @@ package v1alpha1
 
 import (
 	"context"
-
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -71,12 +70,20 @@ var _ = Describe("MysqlCluster CRUD", func() {
 		})
 	})
 
-	Context("defaulting functions", func() {
+	Context("defaulting functions on MySQLCluster", func() {
+		var (
+			cluster *MysqlCluster
+		)
+
+		BeforeEach(func() {
+			cluster = &MysqlCluster{ObjectMeta: metav1.ObjectMeta{Name: "foo1", Namespace: "default"}}
+		})
+
 		It("should populate fields defaults", func() {
-			cluster := &MysqlCluster{ObjectMeta: metav1.ObjectMeta{Name: "foo1", Namespace: "default"}}
 			SetDefaults_MysqlCluster(cluster)
 
 			Expect(cluster.Spec.MysqlConf).NotTo(BeNil())
 		})
 	})
+
 })

pkg/controller/mysqlcluster/mysqlcluster_controller_test.go

@@ -59,6 +59,8 @@ var _ = Describe("MysqlCluster controller", func() {
 		stop chan struct{}
 		// controller k8s client
 		c client.Client
+		// k8s runtime scheme
+		scheme *runtime.Scheme
 	)
 
 	BeforeEach(func() {
@@ -67,6 +69,7 @@ var _ = Describe("MysqlCluster controller", func() {
 		mgr, err := manager.New(cfg, manager.Options{})
 		Expect(err).NotTo(HaveOccurred())
 		c = mgr.GetClient()
+		scheme = mgr.GetScheme()
 
 		recFn, requests = testutil.SetupTestReconcile(newReconciler(mgr))
 		Expect(add(mgr, recFn)).To(Succeed())
@@ -375,6 +378,7 @@ var _ = Describe("MysqlCluster controller", func() {
 
 				Expect(s.OwnerReferences).To(HaveLen(0), "should have no owner reference set")
 			})
+
 		})
 	})
 
@@ -449,6 +453,13 @@ var _ = Describe("MysqlCluster controller", func() {
 		})
 
 	})
+	Context("testing defaults", func() {
+		It("should set the defaults", func() {
+			newCl := &api.MysqlCluster{}
+			scheme.Default(newCl)
+			Expect(newCl.Spec.Replicas).To(PointTo(Equal(int32(1))))
+		})
+	})
 })
 
 func removeAllCreatedResource(c client.Client, clusterComps []runtime.Object) {

pkg/controller/orchestrator/orchestrator_controller_test.go

@@ -119,7 +119,8 @@ var _ = Describe("Orchestrator controller", func() {
 					Namespace: clusterKey.Namespace,
 				},
 				Spec: api.MysqlClusterSpec{
-					Replicas:   &one,
+					// use .replicas as nil for testing propose
+					// Replicas:   &one,
 					SecretName: secret.Name,
 				},
 			})