Change default leader election id, fixes #368

Author: AMecea

pkg/controller/node/node_controller.go

@@ -129,7 +129,6 @@ func add(mgr manager.Manager, r reconcile.Reconciler) error {
 		// also the pod should not be initialized before and should be running because the init
 		// timeout is ~5s (see above) and the cluster status can become obsolete
 		UpdateFunc: func(evt event.UpdateEvent) bool {
-			log.Info("update event", "pod", evt.ObjectNew)
 			return isOwnedByMySQL(evt.MetaNew) && isRunning(evt.ObjectNew) && !isReady(evt.ObjectNew)
 		},
 

pkg/controller/node/node_ctrl_test.go

@@ -129,7 +129,10 @@ var _ = Describe("MysqlNode controller", func() {
 			By("create MySQL pod")
 			pod := getOrCreatePod(c, cluster, 0)
 			setPodPhase(c, pod, corev1.PodRunning)
+			// no event for create
+			// pod update as running
 			Eventually(requests).Should(Receive(Equal(expectedRequest(0))))
+			// pod update for pod conditions (NodeInitializedConditionType)
 			Eventually(requests).Should(Receive(Equal(expectedRequest(0))))
 		})
 
@@ -161,10 +164,12 @@ var _ = Describe("MysqlNode controller", func() {
 			pod1 := getOrCreatePod(c, cluster, 0)
 
 			// when pod is ready should not be triggered a reconcile event
+			By("update pod status to Pending")
 			setPodPhase(c, pod1, corev1.PodPending)
 			Consistently(requests).ShouldNot(Receive(Equal(expectedRequest(0))))
 
 			// mark pod running, should init node
+			By("update pod status to Running")
 			setPodPhase(c, pod1, corev1.PodRunning)
 			Eventually(requests).Should(Receive(Equal(expectedRequest(0))))
 

pkg/options/options.go

@@ -102,7 +102,7 @@ const (
 	defaultOrchestratorTopologyPassword = ""
 
 	defaultLeaderElectionNamespace = "default"
-	defaultLeaderElectionID        = ""
+	defaultLeaderElectionID        = "mysql-operator-leader-election"
 
 	defaultNamespace = ""
 )