Fix pod labeling with node role.

Author: AMecea

pkg/mysqlcluster/pods.go

@@ -33,7 +33,7 @@ func (f *cFactory) updatePodLabels() error {
 		pod, err := getPodForHostname(f.client, f.namespace, f.getLabels(map[string]string{}), ns.Name)
 		if err != nil {
 			glog.Errorf("Failed to update pod labels: %s", err)
-			return err
+			continue
 		}
 
 		labels := pod.GetLabels()
@@ -48,7 +48,6 @@ func (f *cFactory) updatePodLabels() error {
 		glog.V(2).Infof("Inspecting pod: %s, label: %s, desired: %s", pod.Name, val, desiredVal)
 
 		if !exists || val != desiredVal {
-			labels["role"] = desiredVal
 			glog.Infof("Updating labels for Pod: %s", pod.Name)
 
 			meta := metav1.ObjectMeta{
@@ -57,13 +56,19 @@ func (f *cFactory) updatePodLabels() error {
 				OwnerReferences: pod.GetOwnerReferences(),
 				Namespace:       pod.GetNamespace(),
 			}
+
 			_, act, err := kcore.CreateOrPatchPod(f.client, meta,
 				func(in *core.Pod) *core.Pod {
-					in.Labels = labels
+					in.Labels["role"] = desiredVal
 					return in
 				})
+
+			if err != nil {
+				glog.Errorf("Error while updating pod label: %s", err)
+			}
+
 			glog.Infof("Pod %s was %s", pod.Name, getStatusFromKVerb(act))
-			return err
+
 		}
 	}
 

pkg/mysqlcluster/statefullset.go

@@ -20,7 +20,6 @@ import (
 	"fmt"
 
 	kapps "github.com/appscode/kutil/apps/v1"
-	"github.com/golang/glog"
 	apps "k8s.io/api/apps/v1"
 	core "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -82,7 +81,6 @@ func (f *cFactory) syncStatefulSet() (state string, err error) {
 	}
 
 	state = getStatusFromKVerb(act)
-	glog.V(3).Infof("SFS synced state: %s", state)
 	return
 }
 

pkg/mysqlcluster/utils.go

@@ -118,6 +118,12 @@ func (f *cFactory) addNodesToService(serviceName string, hosts ...string) error
 		pods = append(pods, pod)
 	}
 
+	if len(pods) == 0 {
+		// no need to create endpoints, because will fail without addresses
+		glog.V(3).Infof("Nothing to do for hosts: %v, pods not found!", hosts)
+		return nil
+	}
+
 	meta := metav1.ObjectMeta{
 		Name:            serviceName,
 		Labels:          f.getLabels(map[string]string{}),