Make specific function for PodNotFound error

Author: AMecea

pkg/controller/mysqlcluster/internal/syncer/errors.go

@@ -46,12 +46,21 @@ func NewError(code SyncErrCode, syncer, details string) error {
 	}
 }
 
-// IsError check if a error is of given code
-func IsError(err error, code SyncErrCode) bool {
+// NewPodNotFoundError returns a PodNotFound error
+func NewPodNotFoundError() error {
+	return &SyncError{
+		syncer:  "PodSyncer",
+		code:    PodNotFound,
+		details: "",
+	}
+}
+
+// IsPodNotFound check if it's a PodNotFound error
+func IsPodNotFound(err error) bool {
 	switch t := err.(type) {
 	default:
 		return false
 	case *SyncError:
-		return t.code == code
+		return t.code == PodNotFound
 	}
 }

pkg/controller/mysqlcluster/internal/syncer/pod.go

@@ -65,7 +65,7 @@ func (s *podSyncer) SyncFn(in runtime.Object) error {
 
 	// raise error if pod is not created
 	if out.CreationTimestamp.IsZero() {
-		return NewError(PodNotFound, "PodSyncer", "pod is not found")
+		return NewPodNotFoundError()
 	}
 
 	master := s.cluster.GetNodeCondition(s.hostname, api.NodeConditionMaster)

pkg/controller/mysqlcluster/mysqlcluster_controller.go

@@ -200,7 +200,7 @@ func (r *ReconcileMysqlCluster) Reconcile(request reconcile.Request) (reconcile.
 	for _, sync := range r.getPodSyncers(cluster) {
 		if err = syncer.Sync(context.TODO(), sync, r.recorder); err != nil {
 			// if it's pod not found then skip the error
-			if !clustersyncer.IsError(err, clustersyncer.PodNotFound) {
+			if !clustersyncer.IsPodNotFound(err) {
 				return reconcile.Result{}, err
 			}
 		}