Skip pytest fixture functions when collecting.

Fixes #9.

Author: bitprophet

docs/changelog.rst

@@ -2,6 +2,10 @@
 Changelog
 =========
 
+- :bug:`9` Don't try loading Pytest fixture functions as if they were test
+  functions. Classifying this as a bug even though it's a moderately sized
+  change in behavior; it's vanishingly unlikely anybody was relying on this
+  somehow! Thanks to ``@cajopa`` for the report.
 - :release:`2.0.0 <2022-12-31>`
 - :bug:`- major` Prior to version 2, we failed to correctly support true Pytest
   setup/teardown methods (i.e. ``setup_method`` and ``teardown_method``) and

pytest_relaxed/classes.py

@@ -18,11 +18,18 @@ def istestclass(name):
     return not name.startswith("_")
 
 
-def istestfunction(name):
-    return not (
-        name.startswith("_")
-        or name in ("setup", "setup_method", "teardown", "teardown_method")
+# NOTE: this is defined at top level due to a couple spots of reuse outside of
+# the mixin class itself.
+def istestfunction(obj, name):
+    is_hidden_name = name.startswith("_") or name in (
+        "setup",
+        "setup_method",
+        "teardown",
+        "teardown_method",
     )
+    # TODO: is this reliable? how about __pytest_wrapped__?
+    is_fixture = hasattr(obj, "_pytestfixturefunction")
+    return not (is_hidden_name or is_fixture)
 
 
 # All other classes in here currently inherit from PyCollector, and it is what
@@ -45,7 +52,7 @@ def istestclass(self, obj, name):
         return istestclass(name)
 
     def istestfunction(self, obj, name):
-        return istestfunction(name)
+        return istestfunction(obj, name)
 
 
 class SpecModule(RelaxedMixin, Module):
@@ -120,7 +127,7 @@ def _getobj(self):
             if isinstance(value, (types.MethodType, types.FunctionType)):
                 # If they look like tests, they get skipped; don't want to copy
                 # tests around!
-                if istestfunction(name):
+                if istestfunction(obj, name):
                     continue
                 # Non-test == they're probably lifecycle methods
                 # (setup/teardown) or helpers (_do_thing). Rebind them to the

tests/test_collection.py

@@ -179,6 +179,24 @@ def actual_nested_test_here(self):
         assert "actual test here" in stdout
         assert "actual nested test here" in stdout
 
+    def test_skips_pytest_fixtures(self, testdir):
+        testdir.makepyfile(
+            foo="""
+            from pytest import fixture
+
+            @fixture
+            def pls_noload():
+                yield
+
+            def actual_test_here():
+                pass
+        """
+        )
+        stdout = testdir.runpytest("-v").stdout.str()
+        assert "actual test here" in stdout
+        # will be in stdout as a failure and warning if bug present
+        assert "pls_noload" not in stdout
+
     def test_setup_given_inner_class_instances_when_inherited(self, testdir):
         # NOTE: without this functionality in place, we still see setup()
         # called on a per-test-method basis, but where 'self' is the outer