Skip to content

Commit b70810f

Browse files
k-ollyLuca Kollar
andauthored
Hide always_run from WF page and Step bundles page (#1623)
Co-authored-by: Luca Kollar <[email protected]>
1 parent 258211e commit b70810f

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

source/javascripts/components/unified-editor/WhenToRunCard/WhenToRunCard.tsx

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,28 @@ const WhenToRunCard = (props: WhenToRunCardProps) => {
2525
onRunIfChange,
2626
userValuesRunIf,
2727
} = props;
28+
29+
const hideAlwaysRun = false;
2830
return (
2931
<ExpandableCard buttonContent={<Text textStyle="body/lg/semibold">When to run</Text>}>
30-
<Box display="flex" alignItems="center" gap="4" minHeight="32">
31-
<Text flex="1">Run even if previous Step(s) failed</Text>
32-
{!!onIsAlwaysRunReset && (
33-
<IconButton
34-
iconName="Refresh"
35-
aria-label="Reset to default"
36-
size="sm"
37-
variant="tertiary"
38-
onClick={onIsAlwaysRunReset}
39-
/>
40-
)}
41-
<Toggle defaultChecked={isAlwaysRun} onChange={onIsAlwaysRunChange} />
42-
</Box>
43-
<Divider my="24" />
32+
{hideAlwaysRun && (
33+
<>
34+
<Box display="flex" alignItems="center" gap="4" minHeight="32">
35+
<Text flex="1">Run even if previous Step(s) failed</Text>
36+
{!!onIsAlwaysRunReset && (
37+
<IconButton
38+
iconName="Refresh"
39+
aria-label="Reset to default"
40+
size="sm"
41+
variant="tertiary"
42+
onClick={onIsAlwaysRunReset}
43+
/>
44+
)}
45+
<Toggle defaultChecked={isAlwaysRun} onChange={onIsAlwaysRunChange} />
46+
</Box>
47+
<Divider my="24" />
48+
</>
49+
)}
4450
{!!onIsSkippableChange && (
4551
<>
4652
<Box display="flex">

source/javascripts/pages/StepBundlesPage/StepBundlesPage.stories.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
import { Box } from '@bitrise/bitkit';
22
import { Meta, StoryObj } from '@storybook/react';
3+
import { set } from 'es-toolkit/compat';
34

45
import StepBundlesPage from './StepBundlesPage';
56

67
export default {
78
component: StepBundlesPage,
9+
beforeEach: () => {
10+
set(window, 'parent.globalProps.featureFlags.account.enable-wfe-step-bundles-when-to-run', true);
11+
},
812
parameters: {
913
layout: 'fullscreen',
1014
},

0 commit comments

Comments
 (0)