filterLatestProfiles (#59)

* filterLatestProfiles

* latest profile test

Author: godrei

cmd/common.go

@@ -115,6 +115,33 @@ func collectIpaExportSelectableCodeSignGroups(archive xcarchive.IosArchive, inst
 	return codeSignGroups, nil
 }
 
+func filterLatestProfiles(profiles []profileutil.ProvisioningProfileInfoModel) []profileutil.ProvisioningProfileInfoModel {
+	profilesByBundleIDAndName := map[string][]profileutil.ProvisioningProfileInfoModel{}
+	for _, profile := range profiles {
+		bundleID := profile.BundleID
+		name := profile.Name
+		bundleIDAndName := bundleID + name
+		profs, ok := profilesByBundleIDAndName[bundleIDAndName]
+		if !ok {
+			profs = []profileutil.ProvisioningProfileInfoModel{}
+		}
+		profs = append(profs, profile)
+		profilesByBundleIDAndName[bundleIDAndName] = profs
+	}
+
+	filteredProfiles := []profileutil.ProvisioningProfileInfoModel{}
+	for _, profiles := range profilesByBundleIDAndName {
+		var latestProfile *profileutil.ProvisioningProfileInfoModel
+		for _, profile := range profiles {
+			if latestProfile == nil || profile.ExpirationDate.After(latestProfile.ExpirationDate) {
+				latestProfile = &profile
+			}
+		}
+		filteredProfiles = append(filteredProfiles, *latestProfile)
+	}
+	return filteredProfiles
+}
+
 func collectIpaExportCodeSignGroups(archive xcarchive.IosArchive, installedCertificates []certificateutil.CertificateInfoModel, installedProfiles []profileutil.ProvisioningProfileInfoModel) ([]export.IosCodeSignGroup, error) {
 	iosCodeSignGroups := []export.IosCodeSignGroup{}
 
@@ -230,6 +257,7 @@ func collectIpaExportCodeSignGroups(archive xcarchive.IosArchive, installedCerti
 
 		selectedBundleIDProfileMap := map[string]profileutil.ProvisioningProfileInfoModel{}
 		for bundleID, profiles := range bundleIDProfilesMap {
+			profiles = filterLatestProfiles(profiles)
 			profileOptions := []string{}
 			for _, profile := range profiles {
 				profileOption := fmt.Sprintf("%s (%s)", profile.Name, profile.UUID)

cmd/common_test.go

@@ -0,0 +1,57 @@
+package cmd
+
+import (
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/bitrise-tools/go-xcode/profileutil"
+)
+
+func createTime(t *testing.T, timeStr string) time.Time {
+	date, err := time.Parse("2006.01.02", timeStr)
+	require.NoError(t, err)
+	return date
+}
+
+func timeToString(date time.Time) string {
+	return date.Format("2006.01.02")
+}
+
+func Test_filterLatestProfiles(t *testing.T) {
+	profiles := []profileutil.ProvisioningProfileInfoModel{
+		{
+			Name:           "Profile 1",
+			BundleID:       "*",
+			ExpirationDate: createTime(t, "2017.11.01"),
+		},
+		{
+			Name:           "Profile 1",
+			BundleID:       "*",
+			ExpirationDate: createTime(t, "2017.12.01"),
+		},
+		{
+			Name:           "Profile 2",
+			BundleID:       "io.bitrise",
+			ExpirationDate: createTime(t, "2017.10.01"),
+		},
+	}
+
+	filtered := filterLatestProfiles(profiles)
+	require.Equal(t, 2, len(filtered))
+
+	desiredProfileExpireMap := map[string]bool{
+		"2017.12.01": false,
+		"2017.10.01": false,
+	}
+	for _, profile := range filtered {
+		expire := timeToString(profile.ExpirationDate)
+		if _, ok := desiredProfileExpireMap[expire]; ok {
+			desiredProfileExpireMap[expire] = true
+		}
+	}
+	for _, found := range desiredProfileExpireMap {
+		require.True(t, found)
+	}
+}