Skip to content

Commit fbd2787

Browse files
BirmacherAkostrapacska
authored andcommitted
Error log updated for: (#80)
* Error log updated for: "If the xcode archive is success, we have the archive required codesigning files. Then codesigndoc asks for the distribution method, if method selected, which codesigning files are not exist on the developer's machine it mentions the fail, and asks if do you want to export other files? If no selected it finishes with strange error: no ipa export code sign groups collected" * PR clean - fix (+1 squashed commit) Squashed commits: [b19a1ac] PR clean - fix
1 parent 052a329 commit fbd2787

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

codesigndoc/codesigndoc.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
package codesigndoc
22

33
import (
4-
"errors"
54
"fmt"
65
"os"
76

7+
"github.com/bitrise-io/go-utils/colorstring"
8+
89
"github.com/bitrise-io/go-utils/command"
910
"github.com/bitrise-io/go-utils/log"
1011
"github.com/bitrise-io/goinp/goinp"
@@ -72,7 +73,10 @@ func ExportCodesignFiles(archivePath, outputDirPath string, certificatesOnly boo
7273
}
7374

7475
if len(ipaExportCodeSignGroups) == 0 {
75-
return false, false, errors.New("no ipa export code sign groups collected")
76+
errorString := "\n🚨 " + colorstring.Red("Failed to collect codesigning files for the selected distribution type.\n") +
77+
colorstring.Yellow("Export an ipa with the same export method which code signing files you want to collect (e.g app-store if you want to collect the code signing files for app-store distribution) in your local xcode and run codesigndoc again.\n") +
78+
colorstring.Yellow("If the tool fails please report the issue with the codesigndoc log and the local ipa exportOptions.plist")
79+
return false, false, fmt.Errorf(errorString)
7680
}
7781

7882
codeSignGroups := append(ipaExportCodeSignGroups, archiveCodeSignGroup)

codesigndoc/codesigngroup.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ func collectIpaExportCodeSignGroups(archive xcarchive.IosArchive, installedCerti
184184

185185
if len(filteredCodeSignGroups) == 0 {
186186
fmt.Println()
187-
log.Errorf(collectCodesigningFilesInfo)
187+
log.Errorf("🚨 Could not find the codesigning files for %s ipa export:", selectedExportMethod)
188+
log.Warnf(collectCodesigningFilesInfo)
188189
fmt.Println()
189190
fmt.Println()
190191
question := "Do you want to collect another ipa export code sign files"

0 commit comments

Comments
 (0)