Skip to content

Commit bb449fa

Browse files
godreiBirmacherAkos
authored andcommitted
fix errcheck issues (#80)
1 parent d1de0db commit bb449fa

File tree

7 files changed

+22
-6
lines changed

7 files changed

+22
-6
lines changed

log/json_logger.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,7 @@ func NewDefaultJSONLoger() JSONLoger {
2727

2828
// Print ...
2929
func (l JSONLoger) Print(f Formatable) {
30-
fmt.Fprint(l.writer, f.JSON())
30+
if _, err := fmt.Fprint(l.writer, f.JSON()); err != nil {
31+
fmt.Printf("failed to print message: %s, error: %s\n", f.JSON(), err)
32+
}
3133
}

log/print.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ func printf(severity Severity, withTime bool, format string, v ...interface{}) {
1111
message = fmt.Sprintf("%s %s", timestampField(), message)
1212
}
1313

14-
fmt.Fprintln(outWriter, message)
14+
if _, err := fmt.Fprintln(outWriter, message); err != nil {
15+
fmt.Printf("failed to print message: %s, error: %s\n", message, err)
16+
}
1517
}
1618

1719
// Successf ...

log/raw_logger.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,7 @@ func NewDefaultRawLogger() RawLogger {
2727

2828
// Print ...
2929
func (l RawLogger) Print(f Formatable) {
30-
fmt.Fprintln(l.writer, f.String())
30+
if _, err := fmt.Fprintln(l.writer, f.String()); err != nil {
31+
fmt.Printf("failed to print message: %s, error: %s\n", f.String(), err)
32+
}
3133
}

progress/spinner.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ func (s *Spinner) erase() {
4545
n := utf8.RuneCountInString(s.lastOutput)
4646
for _, c := range []string{"\b", " ", "\b"} {
4747
for i := 0; i < n; i++ {
48-
fmt.Fprintf(s.writer, c)
48+
if _, err := fmt.Fprintf(s.writer, c); err != nil {
49+
fmt.Printf("failed to update progress, error: %s\n", err)
50+
}
4951
}
5052
}
5153
s.lastOutput = ""
@@ -68,7 +70,9 @@ func (s *Spinner) Start() {
6870
s.erase()
6971

7072
out := fmt.Sprintf("%s %s", s.message, s.chars[i])
71-
fmt.Fprint(s.writer, out)
73+
if _, err := fmt.Fprint(s.writer, out); err != nil {
74+
fmt.Printf("failed to update progress, error: %s\n", err)
75+
}
7276
s.lastOutput = out
7377

7478
time.Sleep(s.delay)

progress/spinner_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// +build !race
2+
13
package progress
24

35
import (

progress/wrapper.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ func (w Wrapper) WrapAction(action func()) {
4141
if !strings.HasSuffix(message, ".") {
4242
message = message + "..."
4343
}
44-
fmt.Fprintln(w.spinner.writer, message)
44+
if _, err := fmt.Fprintln(w.spinner.writer, message); err != nil {
45+
fmt.Printf("failed to print message: %s, error: %s", message, err)
46+
}
4547
action()
4648
}
4749
}

progress/wrapper_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// +build !race
2+
13
package progress
24

35
import (

0 commit comments

Comments
 (0)