[CI-5849] Enable test video upload feature for everyone (#256)

* [CI-5849] Enable test video upload feature for everyone

* fix: pr comment

* fix: failing tests

* fix: timestamps in test attachements filenames

Author: AndrasEszes

test/test_test.go

@@ -326,53 +326,25 @@ func Test_ParseXctest3Results(t *testing.T) {
 }
 
 func Test_findSupportedAttachments(t *testing.T) {
-	t.Run("without video upload enabled", func(t *testing.T) {
-		os.Unsetenv("ENABLE_TEST_VIDEO_UPLOAD")
-
-		tempDir, err := pathutil.NormalizedOSTempDirPath("test_attachments")
-		require.NoError(t, err)
-		defer os.RemoveAll(tempDir)
-
-		files := []string{
-			"screenshot1.JPG",
-			"screenshot2.png",
-			"log.txt",
-			"video.mp4",
-			"recording.webm",
-			"subfolder/nested.jpg",
-			"subfolder/nested.mp4",
-			"subfolder/deep/image.png",
-		}
-		err = createDummyFilesInDirWithContent(tempDir, "test", files)
-		require.NoError(t, err)
-
-		result := findSupportedAttachments(tempDir, logV2.NewLogger())
-
-		assert.Len(t, result, 5) // jpg, png, txt, nested jpg, nested png (no videos)
-	})
-
-	t.Run("with video upload enabled", func(t *testing.T) {
-		os.Setenv("ENABLE_TEST_VIDEO_UPLOAD", "true")
-		defer os.Unsetenv("ENABLE_TEST_VIDEO_UPLOAD")
-
-		tempDir, err := pathutil.NormalizedOSTempDirPath("test_attachments")
-		require.NoError(t, err)
-		defer os.RemoveAll(tempDir)
-
-		files := []string{
-			"screenshot.JPG",
-			"video.mp4",
-			"recording.webm",
-			"subfolder/nested.png",
-			"subfolder/clip.ogg",
-			"subfolder/deep/image.jpg",
-			"subfolder/deep/movie.mp4",
-		}
-		err = createDummyFilesInDirWithContent(tempDir, "test", files)
-		require.NoError(t, err)
+	tempDir, err := pathutil.NormalizedOSTempDirPath("test_attachments")
+	require.NoError(t, err)
+	defer os.RemoveAll(tempDir)
+
+	files := []string{
+		"screenshot.JPG",
+		"screenshot2.png",
+		"log.txt",
+		"video.mp4",
+		"recording.webm",
+		"subfolder/nested.jpg",
+		"subfolder/clip.ogg",
+		"subfolder/deep/image.png",
+		"subfolder/deep/movie.mp4",
+	}
+	err = createDummyFilesInDirWithContent(tempDir, "test", files)
+	require.NoError(t, err)
 
-		result := findSupportedAttachments(tempDir, logV2.NewLogger())
+	result := findSupportedAttachments(tempDir, logV2.NewLogger())
 
-		assert.Len(t, result, 7) // all files including videos
-	})
+	assert.Len(t, result, 9) // all supported files including videos
 }

test/testasset/testasset.go

@@ -1,25 +1,14 @@
 package testasset
 
 import (
-	"os"
 	"path/filepath"
 	"slices"
 	"strings"
 )
 
-var AssetTypes = []string{".jpg", ".jpeg", ".png", ".txt", ".log"}
-var VideoTypes = []string{".mp4", ".webm", ".ogg"} // These video types are also supported on the UI
+var AssetTypes = []string{".jpg", ".jpeg", ".png", ".txt", ".log", ".mp4", ".webm", ".ogg"}
 
 func IsSupportedAssetType(fileName string) bool {
 	ext := filepath.Ext(fileName)
-
-	if slices.Contains(AssetTypes, strings.ToLower(ext)) {
-		return true
-	}
-
-	if os.Getenv("ENABLE_TEST_VIDEO_UPLOAD") == "true" {
-		return slices.Contains(VideoTypes, strings.ToLower(ext))
-	}
-
-	return false
+	return slices.Contains(AssetTypes, strings.ToLower(ext))
 }

test/testdata/ios_device_config_xml_output.golden

@@ -13,10 +13,14 @@
   <testcase name="testLaunch()" classname="DarkAndLightModeUITestsLaunchTests" time="5">
    <failure></failure>
    <properties>
-    <property name="attachment_0" value="Launch Screen_1_FD1B9BC4-364B-4191-88F9-48DD5B4B251F_1702394166035000085.png"></property>
-    <property name="attachment_1" value="Launch Screen_1_1FDDCFCB-A490-4773-ABC1-96BC97459F6A_1702394182316999912.png"></property>
-    <property name="attachment_2" value="Launch Screen_1_CEFDE93C-2C43-4D5B-80B5-0B27AD09CCC5_1702394197773999929.png"></property>
-    <property name="attachment_3" value="Launch Screen_1_6CD9C2FF-7FFC-4C37-B82A-D208F800193B_1702394211733000040.png"></property>
+    <property name="attachment_0" value="Screen Recording 2023-12-12 at 03.16.02 PM_1702394162331000089.mp4"></property>
+    <property name="attachment_1" value="Launch Screen_1_FD1B9BC4-364B-4191-88F9-48DD5B4B251F_1702394166035000085.png"></property>
+    <property name="attachment_2" value="Screen Recording 2023-12-12 at 03.16.18 PM_1702394178290999889.mp4"></property>
+    <property name="attachment_3" value="Launch Screen_1_1FDDCFCB-A490-4773-ABC1-96BC97459F6A_1702394182316999912.png"></property>
+    <property name="attachment_4" value="Screen Recording 2023-12-12 at 03.16.33 PM_1702394193904999971.mp4"></property>
+    <property name="attachment_5" value="Launch Screen_1_CEFDE93C-2C43-4D5B-80B5-0B27AD09CCC5_1702394197773999929.png"></property>
+    <property name="attachment_6" value="Screen Recording 2023-12-12 at 03.16.47 PM_1702394207775000095.mp4"></property>
+    <property name="attachment_7" value="Launch Screen_1_6CD9C2FF-7FFC-4C37-B82A-D208F800193B_1702394211733000040.png"></property>
    </properties>
   </testcase>
  </testsuite>