[CI-5443] fix test plan configs failure message (#247)

* [CI-5443] Display Test Plan Configuration failure messages

* test: add tests

Author: AndrasEszes

.gitignore

@@ -5,3 +5,4 @@ _tmp
 steps-deploy-to-bitrise-io
 /.idea/
 .env
+.DS_Store

test/converters/xcresult3/converter_test.go

@@ -204,6 +204,30 @@ func TestConverter_XML(t *testing.T) {
 			},
 		}, junitXML.TestSuites)
 	})
+
+	t.Run("xcresult3-multiple-test-plan-configurations.xcresult", func(t *testing.T) {
+		fileName := "xcresult3-multiple-test-plan-configurations.xcresult"
+		rootDir, xcresultPath, err := setupTestData(fileName)
+		require.NoError(t, err)
+		require.NotEmpty(t, rootDir)
+		require.NotEmpty(t, xcresultPath)
+
+		t.Log("tempTestdataDir: ", rootDir)
+
+		c := Converter{xcresultPth: xcresultPath}
+		junitXML, err := c.Convert()
+		require.NoError(t, err)
+		require.NotNil(t, junitXML)
+
+		require.EqualValues(
+			t,
+			junitXML.TestSuites[0].TestCases[0].Failure.Value,
+			`English: swift_testingTests.swift:20: Expectation failed: true == false - // This test is intended to fail to demonstrate test failure reporting.
+German: swift_testingTests.swift:20: Expectation failed: true == false - // This test is intended to fail to demonstrate test failure reporting.
+`,
+		)
+
+	})
 }
 
 func BenchmarkConverter_XML(b *testing.B) {

test/converters/xcresult3/model3/conversion.go

@@ -112,15 +112,35 @@ func extractDuration(text string) time.Duration {
 	return duration
 }
 
+func extractFailureMessageFromTestPlanConfigs(testPlanConfigNodes []TestNode) (string, []string) {
+	var warnings []string
+	failureMessage := ""
+
+	for _, testPlanConfigNode := range testPlanConfigNodes {
+		msg, wrns := extractFailureMessage(testPlanConfigNode)
+		if msg != "" {
+			failureMessage += fmt.Sprintf("%s: %s\n", testPlanConfigNode.Name, msg)
+		}
+		if wrns != nil {
+			warnings = append(warnings, wrns...)
+		}
+	}
+
+	return failureMessage, warnings
+}
+
 func extractFailureMessage(testNode TestNode) (string, []string) {
 	childrenCount := len(testNode.Children)
 	if childrenCount == 0 {
 		return "", nil
 	}
 
-	lastNode := testNode.Children[childrenCount-1]
-	if lastNode.Type == TestNodeTypeRepetition {
-		return extractFailureMessage(lastNode)
+	lastChild := testNode.Children[childrenCount-1]
+	if lastChild.Type == TestNodeTypeRepetition {
+		return extractFailureMessage(lastChild)
+	}
+	if lastChild.Type == TestNodeTypeTestPlanConfig {
+		return extractFailureMessageFromTestPlanConfigs(testNode.Children)
 	}
 
 	var warnings []string