Copy the .ipa/.pkg to tmp folder (#44)

* It will copy the .ipa or .pkg to a tmp folder and rename them to tmp.ipa/tmp.pkg to prevent the fastlane error:
"... in the package contains an invalid character(s). The valid characters are: A-Z, a-z, 0-9, dash, period, underscore, but the name cannot start with a dash, period, or underscore"

* If we can't copy the .ipa/.pkg to the tmp folder we will use the original one.

* build version offset fix;

Author: BirmacherAkos

bitrise.yml

@@ -56,7 +56,7 @@ workflows:
         run_if: true
         inputs:
         - plist_path: $INFO_PLIST_PATH
-        - build_version_offset: 72
+        - build_version_offset: 74
     - xcode-archive:
         title: Create Archive
         inputs:

main.go

@@ -367,7 +367,7 @@ This means that when the API changes
 	}
 
 	if configs.ITMSParameters != "" {
-		envs = append(envs, fmt.Sprintf("DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS=%s", configs.ITMSParameters))	
+		envs = append(envs, fmt.Sprintf("DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS=%s", configs.ITMSParameters))
 	}
 
 	args := []string{
@@ -398,9 +398,20 @@ This means that when the API changes
 	}
 
 	if configs.IpaPath != "" {
-		args = append(args, "--ipa", configs.IpaPath)
+		tmpIpaPath, err := normalizeArtifactPath(configs.IpaPath)
+		if err != nil {
+			log.Warnf("failed to copy the %s to the temporarily dir, error: %s", filepath.Base(configs.IpaPath), err)
+			tmpIpaPath = configs.IpaPath
+		}
+		args = append(args, "--ipa", tmpIpaPath)
+
 	} else if configs.PkgPath != "" {
-		args = append(args, "--pkg", configs.PkgPath)
+		tmpPkgPath, err := normalizeArtifactPath(configs.PkgPath)
+		if err != nil {
+			log.Warnf("failed to copy the %s to the temporarily dir, error: %s", filepath.Base(configs.PkgPath), err)
+			tmpPkgPath = configs.PkgPath
+		}
+		args = append(args, "--pkg", tmpPkgPath)
 	}
 
 	if configs.SkipScreenshots == "yes" {
@@ -443,3 +454,17 @@ This means that when the API changes
 	log.Donef("Success")
 	log.Printf("The app (.ipa) was successfully uploaded to [iTunes Connect](https://itunesconnect.apple.com), you should see it in the *Prerelease* section on the app's iTunes Connect page!")
 }
+
+func normalizeArtifactPath(pth string) (string, error) {
+	tmpDir, err := pathutil.NormalizedOSTempDirPath("ipaOrPkg")
+	if err != nil {
+		return "", err
+	}
+
+	tmpPath := filepath.Join(tmpDir, "tmp"+filepath.Ext(pth))
+	if err := command.CopyFile(pth, tmpPath); err != nil {
+		return "", err
+	}
+
+	return tmpPath, nil
+}