Update step.yml (#55)

* Update step.yml

* Update README

* Update e2e tests

* Set bundle id in static info.plist file

* Add bundle id to example project

Author: godrei

README.md

@@ -40,7 +40,7 @@ to update the version numbers.
 
 ## 🧩 Get started
 
-Add this step directly to your workflow in the [Bitrise Workflow Editor](https://devcenter.bitrise.io/steps-and-workflows/steps-and-workflows-index/).
+Add this step directly to your workflow in the [Bitrise Workflow Editor](https://docs.bitrise.io/en/bitrise-ci/workflows-and-pipelines/steps/adding-steps-to-a-workflow.html).
 
 You can also run this step directly with [Bitrise CLI](https://github.com/bitrise-io/bitrise).
 
@@ -73,9 +73,8 @@ You can also run this step directly with [Bitrise CLI](https://github.com/bitris
 
 We welcome [pull requests](https://github.com/bitrise-steplib/steps-set-xcode-build-number/pulls) and [issues](https://github.com/bitrise-steplib/steps-set-xcode-build-number/issues) against this repository.
 
-For pull requests, work on your changes in a forked repository and use the Bitrise CLI to [run step tests locally](https://devcenter.bitrise.io/bitrise-cli/run-your-first-build/).
+For pull requests, work on your changes in a forked repository and use the Bitrise CLI to [run step tests locally](https://docs.bitrise.io/en/bitrise-ci/bitrise-cli/running-your-first-local-build-with-the-cli.html).
 
 Learn more about developing steps:
 
-- [Create your own step](https://devcenter.bitrise.io/contributors/create-your-own-step/)
-- [Testing your Step](https://devcenter.bitrise.io/contributors/testing-and-versioning-your-steps/)
+- [Create your own step](https://docs.bitrise.io/en/bitrise-ci/workflows-and-pipelines/developing-your-own-bitrise-step/developing-a-new-step.html)

e2e/bitrise.yml

@@ -86,23 +86,21 @@ workflows:
         - build_version_offset: $VERSION_OFFSET
         - build_short_version_string: 9.99.9
         - verbose: "true"
-    - script:
+    - xcode-build-for-simulator:
         title: Build app
         inputs:
-        - content: |
-            #!/bin/bash
-            set -ex
-
-            xcodebuild -$STEP_TYPE $STEP_PATH -scheme $STEP_NAME -sdk iphonesimulator -configuration Release SYMROOT=./build
+        - project_path: $STEP_PATH
+        - scheme: $STEP_NAME
+        - configuration: Release
     - script:
         title: Check version and build numbers
         inputs:
         - content: |
             #!/bin/bash
             set -ex
 
-            buildVersion=$(/usr/libexec/PlistBuddy "$STEP_BUILD_ROOT/build/Release-iphonesimulator/$STEP_NAME.app/Info.plist" -c "print CFBundleVersion")
-            buildShortVersion=$(/usr/libexec/PlistBuddy "$STEP_BUILD_ROOT/build/Release-iphonesimulator/$STEP_NAME.app/Info.plist" -c "print CFBundleShortVersionString")
+            buildVersion=$(/usr/libexec/PlistBuddy "$BITRISE_APP_DIR_PATH/Info.plist" -c "print CFBundleVersion")
+            buildShortVersion=$(/usr/libexec/PlistBuddy "$BITRISE_APP_DIR_PATH/Info.plist" -c "print CFBundleShortVersionString")
 
             if [ "$buildVersion" != "9999" ]; then
               echo "CFBundleVersion is wrong"

step.yml

@@ -39,12 +39,13 @@ type_tags:
 - utility
 
 project_type_tags:
+- cordova
+- flutter
+- ionic
 - ios
+- kotlin-multiplatform
 - macos
 - react-native
-- flutter
-- cordova
-- ionic
 
 toolkit:
   go:

testdata/project/Example/Example/Example-Static-Info.plist

@@ -2,6 +2,8 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
+	<key>CFBundleIdentifier</key>
+	<string>com.iszabi.Example</string>
 	<key>UIApplicationSceneManifest</key>
 	<dict>
 		<key>UIApplicationSupportsMultipleScenes</key>

testdata/workspace/Example/Example/Example-Static-Info.plist

@@ -2,6 +2,8 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
+	<key>CFBundleIdentifier</key>
+	<string>com.iszabi.Example</string>
 	<key>UIApplicationSceneManifest</key>
 	<dict>
 		<key>UIApplicationSupportsMultipleScenes</key>