fix build error: "no case matching constant switch condition" (#1802)

yuguo68 · matthewdouglas · web-flow · commit bcdc4def4f82 · 2025-11-13T10:41:15.000-05:00
* fix switch error * Apply suggestion from @matthewdouglas --------- Co-authored-by: Matthew Douglas <38992547+matthewdouglas@users.noreply.github.com>
diff --git a/csrc/kernels.cu b/csrc/kernels.cu
@@ -557,6 +557,8 @@ __launch_bounds__(BLOCK_SIZE / NUM_VALS, 1) __global__ void kPreconditionOptimiz
                 s1_vals[j] = s1_vals[j] / (sqrtf(s2_vals[j]) + eps); // update
                 s1_vals[j] *= s1_vals[j];                            // update l2 norm (update*update)
                 break;
+            case ADEMAMIX:
+                break;
             }
         }
 
diff --git a/csrc/kernels.hip b/csrc/kernels.hip
@@ -594,6 +594,8 @@ __global__ void kPreconditionOptimizer32bit2State(T* g, T* p,
                   s1_vals[j] = s1_vals[j]/(sqrtf(s2_vals[j])+eps); // update
                   s1_vals[j] *= s1_vals[j]; // update l2 norm (update*update)
                   break;
+              case ADEMAMIX:
+                  break;
           }
       }
 

Original file line number	Diff line number	Diff line change
`@@ -557,6 +557,8 @@ __launch_bounds__(BLOCK_SIZE / NUM_VALS, 1) __global__ void kPreconditionOptimiz`
`557`	`557`	`s1_vals[j] = s1_vals[j] / (sqrtf(s2_vals[j]) + eps); // update`
`558`	`558`	`s1_vals[j] = s1_vals[j]; // update l2 norm (updateupdate)`
`559`	`559`	`break;`
	`560`	`+ case ADEMAMIX:`
	`561`	`+ break;`
`560`	`562`	`}`
`561`	`563`	`}`
`562`	`564`
Original file line number	Diff line number	Diff line change
`@@ -594,6 +594,8 @@ __global__ void kPreconditionOptimizer32bit2State(T* g, T* p,`
`594`	`594`	`s1_vals[j] = s1_vals[j]/(sqrtf(s2_vals[j])+eps); // update`
`595`	`595`	`s1_vals[j] = s1_vals[j]; // update l2 norm (updateupdate)`
`596`	`596`	`break;`
	`597`	`+ case ADEMAMIX:`
	`598`	`+ break;`
`597`	`599`	`}`
`598`	`600`	`}`
`599`	`601`