bug fixes for Error on on fulfills

Author: bitsofinfo

package.json

@@ -1,7 +1,7 @@
 {
     "name":"stateful-process-command-proxy",
-    "version":"1.0.0-beta.3",
-    "description":"Module for executing os commands against a pool of stateful child processes such as bash or powershell via stdout and stderr streams",
+    "version":"1.0.0-beta.4",
+    "description":"Module for executing commands in shells (bash or powershell etc) against a pool of stateful child processes such as bash or powershell via stdout and stderr streams",
     "main":"statefulProcessCommandProxy.js",
     "directories":{
         "test":"test"
@@ -12,7 +12,6 @@
     "keywords":[
         "command",
         "process",
-        "os",
         "dos",
         "unix",
         "commandline",

processProxy.js

@@ -282,7 +282,7 @@ ProcessProxy.prototype._parseRegexes = function(regexesToParse, regexpsToAppendT
 
             } catch(exception) {
                 this._log('error',"Error parsing invalidation regex: "
-                    + regexStr + " err:"+exception);
+                    + regexStr + " err:"+exception + ' ' + exception.stack);
             }
         }
     }
@@ -314,7 +314,7 @@ ProcessProxy.prototype._parseRegexConfigs = function(regexConfigsToConvert) {
         } catch(exception) {
             delete regexConf.regex;
             this._log('error',"Error parsing regex: "
-                + regexStr + " err:"+exception);
+                + regexStr + " err:"+exception + ' ' + exception.stack);
         }
     }
 }
@@ -520,6 +520,10 @@ ProcessProxy.prototype.onData = function(type, data) {
 *
 * initCommands - array of commands to execute after the process
 *                is successfully spawned.
+*
+* Returns a promise
+*  - on fulfill the cmdResults from any initialize comamnds, otherwise fulfill(null)
+*  - on reject, an Error object
 **/
 ProcessProxy.prototype.initialize = function(initCommands) {
 
@@ -554,6 +558,7 @@ ProcessProxy.prototype.initialize = function(initCommands) {
             // register error handler
             self._process.on('error', function(err) {
                 self._log('error','child process received error ' + err);
+                self._isValid = false; // set us to invalid
             });
 
             // register exit handler
@@ -594,7 +599,8 @@ ProcessProxy.prototype.initialize = function(initCommands) {
 
 
         } catch (exception) {
-            self._log('error',"initialize, exception thrown: " + exception);
+            self._log('error',"initialize, exception thrown: "
+                + exception + ' ' + exception.stack);
             reject(exception);
         }
 
@@ -712,7 +718,7 @@ ProcessProxy.prototype._evalRegexConfigs = function(regexConfs, dataToEval) {
 /**
 * executeCommand - takes a raw command statement and returns a promise
 *                  which fulfills/returns {command:cmd, stdout:xxxx, stderr:xxxxx}
-*                  on reject gives an exception
+*                  on reject give an Error object
 *
 **/
 ProcessProxy.prototype.executeCommand = function(command) {
@@ -747,7 +753,8 @@ ProcessProxy.prototype.executeCommand = function(command) {
 * @commands Array of raw command/shell statements to be executed
 *
 * @return Promise, on fulfill returns promise to be fulfilled with a
-*                  array of command results as described above
+*                  array of command results as described above, on reject
+*                  and Error object
 *
 **/
 ProcessProxy.prototype.executeCommands = function(commands) {
@@ -816,7 +823,8 @@ ProcessProxy.prototype.executeCommands = function(commands) {
 *              underlying child process being proxied WILL be KILLED.
 *
 * shutdownCommands - optional array of commands to execute before the process
-*                is attempted to be shutdown.
+*                   is attempted to be shutdown. On fulfill will return cmdResults
+*                   of all destroy commands (if configured), on reject and Error
 **/
 ProcessProxy.prototype.shutdown = function(shutdownCommands) {
 

statefulProcessCommandProxy.js

@@ -148,11 +148,11 @@ function StatefulProcessCommandProxy(config) {
                     callback(null, processProxy);
 
                 }).catch(function(exception) {
-                    self._log('error',"new process initialize threw error: " + exception);
+                    self._log('error',"new process initialize threw error: " + exception + ' ' + exception.stack);
                 });
 
             } catch (exception) {
-                self._log('error',"create: exception: " + exception);
+                self._log('error',"create: exception: " + exception + ' ' + exception.stack);
                 callback(exception, null);
             }
         },
@@ -253,7 +253,7 @@ StatefulProcessCommandProxy.prototype.getStatus = function() {
 
         } catch(exception) {
             self._log('error', "getStatus[process:" +
-                processProxy.getPid() + "]: error: " + e);
+                processProxy.getPid() + "]: error: " + exception);
         }
     }
 
@@ -357,21 +357,21 @@ StatefulProcessCommandProxy.prototype.executeCommands = function(commands) {
                 try {
                     processProxy.executeCommands(commands)
 
-                    .then(function(cmdResults) {
+                        .then(function(cmdResults) {
 
-                        try {
-                            fulfill(cmdResults);
+                            try {
+                                fulfill(cmdResults);
 
-                        } finally {
-                            self._pool.release(processProxy);
-                        }
+                            } finally {
+                                self._pool.release(processProxy);
+                            }
 
-                    }).catch(function(error) {
-                        self._log('error',"executeCommands: [" +
-                            commands + "] error: " + e);
-                        self._pool.release(processProxy);
-                        reject(error);
-                    });
+                        }).catch(function(error) {
+                            self._log('error',"executeCommands: [" +
+                                commands + "] error: " + error);
+                            self._pool.release(processProxy);
+                            reject(error);
+                        });
 
                 } catch (e) {
                     self._log('error',"executeCommands: error: " + e);