Merge pull request #34 from MatkovIvan/fix/feedback-api

Revert feedback API

Author: Benjamin Scholtysik (Reimold)

ExampleGame/Assets/HockeyAppUnityIOS/HockeyAppUnity-Scripts/HockeyAppIOS.cs

@@ -61,6 +61,8 @@ public enum AuthenticatorType
 	[DllImport("__Internal")]
 	private static extern string HockeyApp_GetSdkName();
 	[DllImport("__Internal")]
+	private static extern void HockeyApp_ShowFeedbackListView();
+	[DllImport("__Internal")]
 	private static extern void HockeyApp_CheckForUpdate();
 	#endif
 
@@ -120,10 +122,9 @@ void StartPlugin ()
 	/// <summary>
 	/// Present the modal feedback list user interface.
 	/// </summary>
-	[System.Obsolete("This is an obsolete method")]
 	public static void ShowFeedbackForm() {
 		#if (UNITY_IPHONE && !UNITY_EDITOR)
-		Debug.Log("The method HockeyApp_ShowFeedbackListView() is no longer supported.");
+		HockeyApp_ShowFeedbackListView();
 		#endif
 	}
 

ExampleGame/Assets/HockeyAppUnityIOS/HockeyAppUnity.h

@@ -27,6 +27,7 @@ extern "C" {
 
 #pragma mark - SDK features
 
++ (void)showFeedbackListView;
 + (void)checkForUpdate;
 + (NSString *)versionCode;
 + (NSString *)versionName;

ExampleGame/Assets/HockeyAppUnityIOS/HockeyAppUnityWrapper.m

@@ -12,6 +12,11 @@ void HockeyApp_StartHockeyManager(char *appID, char *serverURL, char *authType,
                              autoSendEnabled:autoSendEnabled];
 }
 
+void HockeyApp_ShowFeedbackListView() {
+  
+  [HockeyAppUnity showFeedbackListView];
+}
+
 void HockeyApp_CheckForUpdate() {
 
   [HockeyAppUnity checkForUpdate];

ExampleGame/Assets/TestUI/TestUI.cs

@@ -76,6 +76,11 @@ void OnGUI(){
 		{	
 			CheckForUpdate();
 		}
+
+        if(GUI.Button(GetControlRect(12), "Show Feedback"))
+        {
+            ShowFeedbackForm();
+        }
 	}
 	public void AutoResize(int screenWidth, int screenHeight){
 
@@ -116,7 +121,12 @@ public void ForceAppCrash(){
 	}
 
 	public void CheckForUpdate(){
-
+        Debug.Log("CheckForUpdate");
 		HockeyAppIOS.CheckForUpdate ();
-	}
+    }
+
+    public void ShowFeedbackForm(){
+        Debug.Log("ShowFeedbackForm");
+        HockeyAppIOS.ShowFeedbackForm ();
+    }
 }

Plugins/HockeyAppUnityIOS/HockeyAppUnity-Scripts/HockeyAppIOS.cs

@@ -61,6 +61,8 @@ public enum AuthenticatorType
 	[DllImport("__Internal")]
 	private static extern string HockeyApp_GetSdkName();
 	[DllImport("__Internal")]
+	private static extern void HockeyApp_ShowFeedbackListView();
+	[DllImport("__Internal")]
 	private static extern void HockeyApp_CheckForUpdate();
 	#endif
 
@@ -120,10 +122,9 @@ void StartPlugin ()
 	/// <summary>
 	/// Present the modal feedback list user interface.
 	/// </summary>
-	[System.Obsolete("This is an obsolete method")]
 	public static void ShowFeedbackForm() {
 		#if (UNITY_IPHONE && !UNITY_EDITOR)
-		Debug.Log("The method HockeyApp_ShowFeedbackListView() is no longer supported.");
+		HockeyApp_ShowFeedbackListView();
 		#endif
 	}
 

Plugins/HockeyAppUnityIOS/HockeyAppUnity.h

@@ -27,6 +27,7 @@ extern "C" {
 
 #pragma mark - SDK features
 
++ (void)showFeedbackListView;
 + (void)checkForUpdate;
 + (NSString *)versionCode;
 + (NSString *)versionName;

Plugins/HockeyAppUnityIOS/HockeyAppUnityWrapper.m

@@ -12,6 +12,11 @@ void HockeyApp_StartHockeyManager(char *appID, char *serverURL, char *authType,
                              autoSendEnabled:autoSendEnabled];
 }
 
+void HockeyApp_ShowFeedbackListView() {
+  
+  [HockeyAppUnity showFeedbackListView];
+}
+
 void HockeyApp_CheckForUpdate() {
 
   [HockeyAppUnity checkForUpdate];

README.md

@@ -4,7 +4,7 @@
 ### Feedback and iOS 10 and later
 **This version brings back the Feedback feature**
 
-The reason for this is that iOS 10 ant later require developers to add a usage string to their Info.plist in case they include the photos framework in their app. If this string is missing, the app will be rejected when submitting the app to the app store. As HockeyApp's Feedback feature includes a dependency to the photos framework. 
+The reason for this is that iOS 10 and later require developers to add a usage string to their Info.plist in case they include the photos framework in their app. If this string is missing, the app will be rejected when submitting the app to the app store. As HockeyApp's Feedback feature includes a dependency to the photos framework. 
 You must add a `NSPhotoLibraryUsageDescription` to your `Info.plist` to avoid a AppStore rejection during upload of your app.
 
 ## Introduction 
@@ -38,7 +38,7 @@ This document contains the following sections:
 ## <a name="1"></a>Requirements
 * [Changelog](Documentation/Changelog.md)
 * Unity 5.0 or newer (SDK versions with Unity 4 support can be found at the [Unity Asset Store](https://www.assetstore.unity3d.com/en/?gclid=CO) or by switching to the 1.0.4 tag on GitHub).
-* iOS 7.0 or newer.
+* iOS 8.0 or newer.
 
 ## <a name="2"></a>Installation & Setup
 

UnityPluginSources/HockeyAppUnity/HockeyAppUnity.h

@@ -27,6 +27,7 @@ extern "C" {
 
 #pragma mark - SDK features
 
++ (void)showFeedbackListView;
 + (void)checkForUpdate;
 + (NSString *)versionCode;
 + (NSString *)versionName;

UnityPluginSources/HockeyAppUnity/HockeyAppUnity.m

@@ -67,6 +67,10 @@ + (BOOL)handleOpenURL:(NSURL *) url sourceApplication:(NSString *) sourceApplica
 
 #pragma mark - Setup SDK
 
++ (void)showFeedbackListView {
+  [[BITHockeyManager sharedHockeyManager].feedbackManager showFeedbackListView];
+}
+
 + (void)checkForUpdate {
   [[BITHockeyManager sharedHockeyManager].updateManager checkForUpdate];
 }