Skip to content

Commit 0f74c36

Browse files
authored
revert booleans to strings (#447)
1 parent baccdce commit 0f74c36

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

.github/workflows/test-all-custom-flags.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
4141
- name: Log in to Azure
4242
uses: bitwarden/gh-actions/azure-login@main
43-
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == true
43+
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
4444
with:
4545
subscription_id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
4646
tenant_id: ${{ secrets.AZURE_TENANT_ID }}
@@ -49,19 +49,19 @@ jobs:
4949
- name: Get Azure Key Vault secrets
5050
id: get-kv-secrets
5151
uses: bitwarden/gh-actions/get-keyvault-secrets@main
52-
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == true
52+
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
5353
with:
5454
keyvault: gh-org-bitwarden
5555
secrets: "BW-GHAPP-ID,BW-GHAPP-KEY"
5656

5757
- name: Log out from Azure
5858
uses: bitwarden/gh-actions/azure-logout@main
59-
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == true
59+
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
6060

6161
- name: Generate GH App token
6262
id: app-token
6363
uses: actions/create-github-app-token@30bf6253fa41bdc8d1501d202ad15287582246b4 # v2.0.3
64-
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == true
64+
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
6565
with:
6666
app-id: ${{ steps.get-kv-secrets.outputs.BW-GHAPP-ID }}
6767
private-key: ${{ steps.get-kv-secrets.outputs.BW-GHAPP-KEY }}
@@ -200,7 +200,7 @@ jobs:
200200
201201
- name: Remove past BIT status comments on originating issue
202202
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
203-
if: (success() || (failure() && steps.get-build-artifact.conclusion == 'success')) && steps.set-send-pr-feedback.outputs.send_pr_feedback == true
203+
if: (success() || (failure() && steps.get-build-artifact.conclusion == 'success')) && steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
204204
with:
205205
github-token: ${{ steps.app-token.outputs.token }}
206206
script: |
@@ -240,7 +240,7 @@ jobs:
240240
241241
- name: Communicate BIT failure on originating issue
242242
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
243-
if: failure() && steps.get-build-artifact.conclusion == 'success' && steps.set-send-pr-feedback.outputs.send_pr_feedback == true
243+
if: failure() && steps.get-build-artifact.conclusion == 'success' && steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
244244
env:
245245
FEATURE_FLAGS: ${{ inputs.FEATURE_FLAGS || '{}' }}
246246
with:
@@ -275,7 +275,7 @@ jobs:
275275
276276
- name: Communicate BIT success on originating issue
277277
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
278-
if: success() && steps.set-send-pr-feedback.outputs.send_pr_feedback == true
278+
if: success() && steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
279279
env:
280280
FEATURE_FLAGS: ${{ inputs.FEATURE_FLAGS || '{}' }}
281281
with:

.github/workflows/test-all.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
4040
- name: Log in to Azure
4141
uses: bitwarden/gh-actions/azure-login@main
42-
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == true
42+
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
4343
with:
4444
subscription_id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
4545
tenant_id: ${{ secrets.AZURE_TENANT_ID }}
@@ -48,19 +48,19 @@ jobs:
4848
- name: Get Azure Key Vault secrets
4949
id: get-kv-secrets
5050
uses: bitwarden/gh-actions/get-keyvault-secrets@main
51-
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == true
51+
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
5252
with:
5353
keyvault: gh-org-bitwarden
5454
secrets: "BW-GHAPP-ID,BW-GHAPP-KEY"
5555

5656
- name: Log out from Azure
5757
uses: bitwarden/gh-actions/azure-logout@main
58-
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == true
58+
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
5959

6060
- name: Generate GH App token
6161
id: app-token
6262
uses: actions/create-github-app-token@30bf6253fa41bdc8d1501d202ad15287582246b4 # v2.0.3
63-
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == true
63+
if: steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
6464
with:
6565
app-id: ${{ steps.get-kv-secrets.outputs.BW-GHAPP-ID }}
6666
private-key: ${{ steps.get-kv-secrets.outputs.BW-GHAPP-KEY }}
@@ -201,7 +201,7 @@ jobs:
201201
202202
- name: Remove past BIT status comments on originating issue
203203
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
204-
if: (success() || (failure() && steps.get-build-artifact.conclusion == 'success')) && steps.set-send-pr-feedback.outputs.send_pr_feedback == true
204+
if: (success() || (failure() && steps.get-build-artifact.conclusion == 'success')) && steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
205205
with:
206206
github-token: ${{ steps.app-token.outputs.token }}
207207
script: |
@@ -241,7 +241,7 @@ jobs:
241241
242242
- name: Communicate BIT failure on originating issue
243243
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
244-
if: failure() && steps.get-build-artifact.conclusion == 'success' && steps.set-send-pr-feedback.outputs.send_pr_feedback == true
244+
if: failure() && steps.get-build-artifact.conclusion == 'success' && steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
245245
env:
246246
REMOTE_VAULT_CONFIG: ${{ vars.BW_REMOTE_VAULT_CONFIG_MATCH }}
247247
with:
@@ -273,7 +273,7 @@ jobs:
273273
274274
- name: Communicate BIT success on originating issue
275275
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
276-
if: success() && steps.set-send-pr-feedback.outputs.send_pr_feedback == true
276+
if: success() && steps.set-send-pr-feedback.outputs.send_pr_feedback == 'true'
277277
env:
278278
REMOTE_VAULT_CONFIG: ${{ vars.BW_REMOTE_VAULT_CONFIG_MATCH }}
279279
with:

0 commit comments

Comments
 (0)