Skip to content

Commit a8b5928

Browse files
committed
additional fixes
1 parent 351bf4a commit a8b5928

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.github/workflows/test-all-custom-flags.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
branch: ${{ github.event.client_payload.origin_branch || inputs.CLIENTS_BRANCH || 'main' }}
7575
name: ^dist-chrome-MV3-\w{7}\.zip$
7676
name_is_regexp: true
77-
repo: bitwarden/clients
77+
repo: jprusik/clients
7878
if_no_artifact_found: fail
7979
skip_unpack: true
8080

@@ -158,15 +158,17 @@ jobs:
158158
github-token: ${{ secrets.GITHUB_TOKEN }}
159159
script: |
160160
const owner = 'bitwarden';
161+
const featureFlags = ${{ inputs.FEATURE_FLAGS }};
162+
const runURL = `https://github.com/${owner}/browser-interactions-testing/actions/runs/${context.runId}`;
161163
const message = `⚠️ **Files have been modified in this PR that impact the Autofill experience** ⚠️
162164
163-
[BIT](https://github.com/${owner}/browser-interactions-testing) was run to verify no regressions have been introduced to the core Autofill experience. The tests ran with ${{ inputs.FEATURE_FLAGS === '{}' ? 'all feature flags disabled.': '\n\n<details><summary><div>The following flags enabled:</div></summary>```json\n${{inputs.FEATURE_FLAGS}}```'}
165+
[BIT](https://github.com/${owner}/browser-interactions-testing) was run to verify no regressions have been introduced to the core Autofill experience. The tests ran with ${ featureFlags === '{}' ? 'all feature flags disabled.': '\n\n<details><summary><div>The following flags enabled:</div></summary>```json\n${ featureFlags }```'}}
164166
165167
❌ Unfortunately, one or more of these BIT tests failed. 😞
166168
167169
Please resolve the failure before merging; reach out to `@bitwarden/team-autofill-dev` if you'd like help.
168170
169-
You can view the detailed results of the tests [here](https://github.com/${owner}/browser-interactions-testing/actions/runs/${context.runId}).`;
171+
You can view the detailed results of the tests [here](${runURL}).`;
170172
171173
github.rest.issues.createComment({
172174
issue_number: context.payload.client_payload.origin_issue,

.github/workflows/test-all.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,15 +158,16 @@ jobs:
158158
github-token: ${{ secrets.GITHUB_TOKEN }}
159159
script: |
160160
const owner = 'bitwarden';
161+
const runURL = `https://github.com/${owner}/browser-interactions-testing/actions/runs/${context.runId}`;
161162
const message = `⚠️ **Files have been modified in this PR that impact the Autofill experience** ⚠️
162163
163-
[BIT](https://github.com/${owner}/browser-interactions-testing) was run to verify no regressions have been introduced to the core Autofill experience. The tests ran with the same feature flag configuration used by the `${{ REMOTE_VAULT_CONFIG_MATCH || 'US production'}}` server.
164+
[BIT](https://github.com/${owner}/browser-interactions-testing) was run to verify no regressions have been introduced to the core Autofill experience. The tests ran with the same feature flag configuration used by the `${{ vars.BW_REMOTE_VAULT_CONFIG_MATCH || 'US production' }}` server.
164165
165166
❌ Unfortunately, one or more of these BIT tests failed. 😞
166167
167168
Please resolve the failure before merging; reach out to `@bitwarden/team-autofill-dev` if you'd like help.
168169
169-
You can view the detailed results of the tests [here](https://github.com/${owner}/browser-interactions-testing/actions/runs/${context.runId}).`;
170+
You can view the detailed results of the tests [here](${runURL}).`;
170171
171172
github.rest.issues.createComment({
172173
issue_number: context.payload.client_payload.origin_issue,

0 commit comments

Comments
 (0)