[PM-19462] Update a11y testing (#321)

* update web fixture login

* update web client a11y test paths

* update browser client a11y test paths

Author: jprusik

constants/browser-client-views.ts

@@ -1,27 +1,33 @@
 export const browserClientViewPaths = new Set([
-  "register",
-  "home",
-  "environment",
+  "signup",
+  "hint",
   "[email protected]",
   "account-switcher",
-  "add-cipher",
+  "add-cipher?type=1",
+  "add-cipher?type=2",
+  "add-cipher?type=3",
+  "add-cipher?type=4",
+  "add-cipher?type=5",
+  "add-cipher?type=6",
   "tabs/vault",
   "tabs/send",
-  "add-send",
+  "add-send?type=1",
+  "add-send?type=2",
   "tabs/generator",
   "generator-history",
   "tabs/settings",
   "account-security",
   "autofill",
+  "blocked-domains",
   "notifications",
   "excluded-domains",
   "folders",
   "vault-settings",
   "export",
+  "trash",
   "appearance",
   "about",
   "more-from-bitwarden",
   "premium",
+  "lock",
 ]);
-
-export const browserClientViewPathsRefreshUI = new Set(["lockV2", "trash"]);

constants/web-client-views.ts

@@ -7,16 +7,23 @@ export const authenticatedWebClientViewPaths = new Set([
   "tools/export",
   "reports",
   "reports/breach-report",
+  "reports/exposed-passwords-report",
+  "reports/reused-passwords-report",
+  "reports/weak-passwords-report",
+  "reports/unsecured-websites-report",
+  "reports/inactive-two-factor-report",
   "settings/account",
   "settings/security/change-password",
   "settings/security/two-factor",
+  "settings/security/device-management",
   "settings/security/security-keys",
   "settings/preferences",
-  "settings/subscription/premium",
+  "settings/subscription/premium", // # non-premium accounts only
   "settings/domain-rules",
   "settings/emergency-access",
   "settings/sponsored-families",
   "create-organization",
+  // @TODO secrets manager & admin console
 ]);
 
 export const unauthenticatedWebClientViewPaths = new Set([

tests/a11y/browser-client.spec.ts

@@ -1,6 +1,5 @@
 import {
   browserClientViewPaths,
-  browserClientViewPathsRefreshUI,
   debugIsActive,
   messageColor,
 } from "../../constants";
@@ -12,18 +11,14 @@ test.describe("Browser client", { tag: ["@browser-client", "@a11y"] }, () => {
     extensionId,
     extensionSetup,
   }, testInfo) => {
-    const urlSharedPathBase = "popout#/";
-    const urlBase = `chrome-extension://${extensionId}/popup/index.html?uilocation=popout#/`;
+    const urlSharedPathBase = "#/";
+    const urlBase = `chrome-extension://${extensionId}/popup/index.html${urlSharedPathBase}`;
 
     let testPage = await extensionSetup;
     let violationsCount = 0;
-    let viewPaths = [
-      ...browserClientViewPaths,
-      ...browserClientViewPathsRefreshUI,
-    ];
 
     // Note: if a path is nonexistent, it will load to the vault tab and evaluate that
-    for (const viewPath of viewPaths) {
+    for (const viewPath of browserClientViewPaths) {
       await test.step(`for path: \`${urlSharedPathBase}${viewPath}\``, async () => {
         const newViolationsCount = await a11yTestView({
           testInfo,
@@ -36,7 +31,7 @@ test.describe("Browser client", { tag: ["@browser-client", "@a11y"] }, () => {
         await expect
           .soft(
             newViolationsCount,
-            `view for \`popout#/${viewPath}\` should yield 0 violations`,
+            `view for \`${urlSharedPathBase}${viewPath}\` should yield 0 violations`,
           )
           .toEqual(0);
 

tests/fixtures.web.ts

@@ -76,9 +76,7 @@ export const test = base.extend<{
       const emailSubmitInput = await testPage.getByRole("button");
       await emailSubmitInput.click();
 
-      const masterPasswordInput = await testPage.locator(
-        "input#login_input_master-password",
-      );
+      const masterPasswordInput = await testPage.getByLabel("Master password");
       await masterPasswordInput.waitFor(defaultWaitForOptions);
       await masterPasswordInput.fill(vaultPassword);