Skip to content

Commit b5bb214

Browse files
committed
further additional tweaks
1 parent 27d633b commit b5bb214

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/test-all-custom-flags.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,15 +158,16 @@ jobs:
158158
github-token: ${{ secrets.GITHUB_TOKEN }}
159159
script: |
160160
const owner = 'bitwarden';
161-
const featureFlags = ${{ inputs.FEATURE_FLAGS }};
161+
const featureFlags = "${{ inputs.FEATURE_FLAGS || '{}' }}";
162+
const featureFlagsMessage = featureFlags === '{}' ? 'all feature flags disabled.': `\n\n<details><summary><div>The following flags enabled:</div></summary>\`\`\`json\n${featureFlags}\`\`\``;
162163
const runURL = `https://github.com/${owner}/browser-interactions-testing/actions/runs/${context.runId}`;
163164
const message = `⚠️ **Files have been modified in this PR that impact the Autofill experience** ⚠️
164165
165-
[BIT](https://github.com/${owner}/browser-interactions-testing) was run to verify no regressions have been introduced to the core Autofill experience. The tests ran with ${ featureFlags === '{}' ? 'all feature flags disabled.': '\n\n<details><summary><div>The following flags enabled:</div></summary>\`\`\`json\n${ featureFlags }\`\`\`'}}
166+
[BIT](https://github.com/${owner}/browser-interactions-testing) was run to verify no regressions have been introduced to the core Autofill experience. The tests ran with ${featureFlagsMessage}
166167
167168
❌ Unfortunately, one or more of these BIT tests failed. 😞
168169
169-
Please resolve the failure before merging- reach out to \`@bitwarden/team-autofill-dev\` if you'd like help.
170+
Please resolve the failure before merging; reach out to \`@bitwarden/team-autofill-dev\` if you'd like help.
170171
171172
You can view the detailed results of the tests [here](${runURL}).`;
172173

.github/workflows/test-all.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,10 @@ jobs:
159159
script: |
160160
const owner = 'bitwarden';
161161
const runURL = `https://github.com/${owner}/browser-interactions-testing/actions/runs/${context.runId}`;
162+
const configURL = new URL('${{ vars.BW_REMOTE_VAULT_CONFIG_MATCH }}');
162163
const message = `⚠️ **Files have been modified in this PR that impact the Autofill experience** ⚠️
163164
164-
[BIT](https://github.com/${owner}/browser-interactions-testing) was run to verify no regressions have been introduced to the core Autofill experience. The tests ran with the same feature flag configuration used by the \`${{ vars.BW_REMOTE_VAULT_CONFIG_MATCH || 'US production' }}\` server.
165+
[BIT](https://github.com/${owner}/browser-interactions-testing) was run to verify no regressions have been introduced to the core Autofill experience. The tests ran with the same feature flag configuration used by \`${configURL.hostname}\`
165166
166167
❌ Unfortunately, one or more of these BIT tests failed. 😞
167168

0 commit comments

Comments
 (0)