Make deviceAuthenticator fallible

Author: iinuwa

BitwardenShared/Core/Auth/Services/ClientFido2Service.swift

@@ -15,19 +15,7 @@ protocol ClientFido2Service: AnyObject {
         userInterface: Fido2UserInterface,
         credentialStore: Fido2CredentialStore,
     ) -> ClientFido2AuthenticatorProtocol
-    
-    /// - Parameters:
-    ///   - userInterface: `Fido2UserInterface` with necessary platform side logic related to UI.
-    ///   - credentialStore: `Fido2CredentialStore` with necessary platform side logic related to credential storage.
-    ///   - deviceKey: `SymmetricKey` used to encrypt data on the device.
-    /// - Returns: Returns the `ClientFido2Authenticator` to perform Fido2 authenticator tasks
-    func deviceAuthenticator(
-        userInterface: Fido2UserInterface,
-        credentialStore: Fido2CredentialStore,
-        deviceKey: SymmetricKey,
-    ) -> ClientFido2AuthenticatorProtocol
 
-    /// Returns the `ClientFido2Authenticator` to perform Fido2 authenticator tasks on keychain items.
     /// - Parameters:
     ///   - userInterface: `Fido2UserInterface` with necessary platform side logic related to UI.
     ///   - credentialStore: `Fido2CredentialStore` with necessary platform side logic related to credential storage.
@@ -36,8 +24,8 @@ protocol ClientFido2Service: AnyObject {
     func deviceAuthenticator(
         userInterface: Fido2UserInterface,
         credentialStore: Fido2CredentialStore,
-        deviceKey: SymmetricKey
-    ) -> ClientFido2AuthenticatorProtocol
+        deviceKey: SymmetricKey,
+    ) throws -> ClientFido2AuthenticatorProtocol
 
     /// Returns the `ClientFido2Client` to perform Fido2 client tasks.
     /// - Parameters:
@@ -75,11 +63,11 @@ extension ClientFido2: ClientFido2Service {
         userInterface: Fido2UserInterface,
         credentialStore: Fido2CredentialStore,
         deviceKey: SymmetricKey,
-    ) -> ClientFido2AuthenticatorProtocol {
+    ) throws -> ClientFido2AuthenticatorProtocol {
         let encryptionKey = deviceKey.withUnsafeBytes { bytes in
             Data(Array(bytes))
         }
-        return deviceAuthenticator(
+        return try deviceAuthenticator(
             userInterface: userInterface,
             credentialStore: credentialStore,
             encryptionKey: encryptionKey