Skip to content

Commit 55c14dd

Browse files
authored
[PM-25652] Remove deprecated update_password (#559)
## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-25652 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> The objective of this change it to remove the deprecated method `update_password` from the mobile crypto client. Mobile teams have already migrated see: bitwarden/ios#1996 bitwarden/android#5916 ## 🚨 Breaking Changes <!-- Does this PR introduce any breaking changes? If so, please describe the impact and migration path for clients. If you're unsure, the automated TypeScript compatibility check will run when you open/update this PR and provide feedback. For breaking changes: 1. Describe what changed in the client interface 2. Explain why the change was necessary 3. Provide migration steps for client developers 4. Link to any paired client PRs if needed Otherwise, you can remove this section. --> This is technically a breaking change as in the API is being removed. However teams have already migrated off of it. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
1 parent 7080159 commit 55c14dd

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

crates/bitwarden-core/src/key_management/crypto.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ pub(super) fn make_update_kdf(
360360
})
361361
}
362362

363-
/// Response from the `update_password` function
363+
/// Response from the `make_update_password` function
364364
#[derive(Serialize, Deserialize, Debug)]
365365
#[serde(rename_all = "camelCase", deny_unknown_fields)]
366366
#[cfg_attr(feature = "uniffi", derive(uniffi::Record))]

crates/bitwarden-uniffi/src/crypto.rs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,6 @@ impl CryptoClient {
3131
Ok(self.0.get_user_encryption_key().await?)
3232
}
3333

34-
/// Create the data necessary to update the user's password. The user's encryption key is
35-
/// re-encrypted with the new password. This returns the new encrypted user key and the new
36-
/// password hash but does not update sdk state.
37-
///
38-
/// Note: This is deprecated and `make_update_password` should be used instead
39-
pub fn update_password(&self, new_password: String) -> Result<UpdatePasswordResponse> {
40-
self.make_update_password(new_password)
41-
}
42-
4334
/// Create the data necessary to update the user's password. The user's encryption key is
4435
/// re-encrypted with the new password. This returns the new encrypted user key and the new
4536
/// password hash but does not update sdk state.

0 commit comments

Comments
 (0)