Apply clippy fixes

Author: quexten

crates/bitwarden-core/src/client/encryption_settings.rs

@@ -66,12 +66,7 @@ impl EncryptionSettings {
         // state to be missing, because they are *always* present when the user key is an
         // XChaCha20Poly1305Key. Thus, the server or network cannot lie about the presence of these,
         // because otherwise the entire user account will fail to decrypt.
-        let is_v2_user = if let SymmetricCryptoKey::XChaCha20Poly1305Key(_) = user_key {
-            true
-        } else {
-            false
-        };
-
+        let is_v2_user = matches!(user_key, SymmetricCryptoKey::XChaCha20Poly1305Key(_));
         if is_v2_user {
             // For v2 users, we mandate the signing key and security state to be present
             // The private key must also be valid.

crates/bitwarden-crypto/src/security_state.rs

@@ -72,7 +72,7 @@ pub fn sign<Ids: KeyIds>(
     ctx: &mut KeyStoreContext<Ids>,
 ) -> Result<SignedSecurityState, CryptoError> {
     let signing_key = ctx.get_signing_key(signing_key_id)?;
-    security_state.sign(&signing_key)
+    security_state.sign(signing_key)
 }
 
 impl SignedSecurityState {
@@ -81,9 +81,9 @@ impl SignedSecurityState {
         self,
         verifying_key: &VerifyingKey,
     ) -> Result<SecurityState, CryptoError> {
-        Ok(self
+        self
             .0
-            .verify_and_unwrap(verifying_key, &SigningNamespace::SecurityState)?)
+            .verify_and_unwrap(verifying_key, &SigningNamespace::SecurityState)
     }
 }