[PM-18102] Use opaque autogenerated local key ids #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-garcia
changed the title
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
- Coverage 75.88% 75.86% -0.02%
==========================================
Files 259 259
Lines 23726 23671 -55
==========================================
- Hits 18004 17959 -45
+ Misses 5722 5712 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # crates/bitwarden-crypto/src/store/context.rs # crates/bitwarden-crypto/src/traits/key_id.rs
# Conflicts: # crates/bitwarden-crypto/src/store/context.rs # crates/bitwarden-vault/src/cipher/attachment.rs # crates/bitwarden-wasm-internal/src/pure_crypto.rs
|
# Conflicts: # crates/bitwarden-core/src/key_management/crypto.rs # crates/bitwarden-crypto/src/store/context.rs # crates/bitwarden-vault/src/cipher/cipher.rs # crates/bitwarden-wasm-internal/src/pure_crypto.rs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18102
📔 Objective
This would avoid having to declare them ahead of time, and ensure no one can accidentally overwrite them.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes